Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DbSet to not use CommandGenerator directly #2

Open
LukasSefcik opened this issue Mar 22, 2019 · 0 comments
Open

Modify DbSet to not use CommandGenerator directly #2

LukasSefcik opened this issue Mar 22, 2019 · 0 comments

Comments

@LukasSefcik
Copy link
Collaborator

  • Modify DbSet to not use CommandGenerator directly, but only IQueryProvider.
  • CommandGenerator is class for creating commands for DbSet. But in case of database connection, it relies on IQueryProvider. IQueryProvider creates instance of DbCommand, because it knows database connection. Because of that, there is useless method GetCommandForCurrentTransaction.
  • It would be great if the DbSet will be dependent only on IQueryProvider and IQueryProvider will use CommandGenerator inside. Consider deleting CommandGenerator and moving code to IQueryProvider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant