fix(plugin): #181 Properly execute npm scripts

Author: mpetuska

CHANGELOG.md

@@ -23,6 +23,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [3.5.2]
+
+### Verified Versions
+
+- Kotlin: 2.1.0
+- Gradle: 8.12
+- JDK: 21
+
+### Added
+
+### Changed
+
+- Fix #181 - npm commands are failing when node is not on PATH.
+
+### Removed
+
+---
+
 ## [3.5.1]
 
 ### Verified Versions
@@ -185,7 +203,7 @@ This is a maintenance release with a few minor bugfixes.
 ### Added
 
 - New `tag` option for `NpmPublishTask`
-- Integration with `com.netflix.nebula:nebula-node-plugin` to allow publishing without having NodeJS installed when
+- Integration with `com.github.node-gradle.node` to allow publishing without having NodeJS installed when
   kotlin plugin is not being used
 
 ### Changed
@@ -490,10 +508,12 @@ This is a maintenance release with a few minor bugfixes.
 
 ---
 
-[Unreleased]: https://github.com/mpetuska/npm-publish/compare/3.5.1...HEAD
+[Unreleased]: https://github.com/mpetuska/npm-publish/compare/3.5.2...HEAD
 
 [3.5.1]: https://github.com/mpetuska/npm-publish/compare/3.5.0...3.5.1
 
+[3.5.2]: https://github.com/mpetuska/npm-publish/compare/3.5.1...3.5.2
+
 [3.5.0]: https://github.com/mpetuska/npm-publish/compare/3.4.2...3.5.0
 
 [3.4.2]: https://github.com/mpetuska/npm-publish/compare/3.4.1...3.4.2

npm-publish-docs/src/docs/user-guide/configuration/extension.md

@@ -77,7 +77,7 @@ Default NodeJS directory to be used when executing npm commands.
 !!! info
     This is set automatically when certain other plugins are applied
     - `org.jetbrains.kotlin.multiplatform` & `org.jetbrains.kotlin.js`: `kotlinNodeJsSetup` task output
-    - `com.netflix.nebula:nebula-node-plugin`: `nodeSetup` task output
+    - `com.github.node-gradle.node`: `nodeSetup` task's `NodeSetupTask::nodeDir` property
 
 ### `nodeBin`
 

npm-publish-gradle-plugin/src/main/kotlin/NpmPublishPlugin.kt

@@ -1,7 +1,7 @@
 package dev.petuska.npm.publish
 
 import dev.petuska.npm.publish.config.configure
-import dev.petuska.npm.publish.config.configureNebulaNode
+import dev.petuska.npm.publish.config.configureNodeGradlePlugin
 import dev.petuska.npm.publish.extension.NpmPublishExtension
 import dev.petuska.npm.publish.task.NodeExecTask
 import dev.petuska.npm.publish.task.NpmAssembleTask
@@ -26,7 +26,7 @@ public class NpmPublishPlugin : Plugin<Project> {
   override fun apply(project: Project): Unit = with(project) {
     val extension = extensions.create(NpmPublishExtension.NAME, NpmPublishExtension::class.java)
     configure(extension)
-    configureNebulaNode(extension)
+    configureNodeGradlePlugin(extension)
     pluginManager.withPlugin(KOTLIN_MPP_PLUGIN) {
       extensions.configure<KotlinMultiplatformExtension> {
         targets.filterIsInstance<KotlinJsTargetDsl>().forEach { configure(it) }

npm-publish-gradle-plugin/src/main/kotlin/config/nebulaNode.kt renamed to npm-publish-gradle-plugin/src/main/kotlin/config/nodeGradlePlugin.kt

@@ -11,7 +11,7 @@ import org.jetbrains.kotlin.gradle.utils.named
 
 private const val NODE_GRADLE_PLUGIN = "com.github.node-gradle.node"
 
-internal fun Project.configureNebulaNode(extension: NpmPublishExtension) {
+internal fun Project.configureNodeGradlePlugin(extension: NpmPublishExtension) {
   pluginManager.withPlugin(NODE_GRADLE_PLUGIN) {
     val nodeGradleHome = project.tasks.named<NodeSetupTask>(NodeSetupTask.NAME)
       .map { it.takeIf { it.enabled }.unsafeCast<NodeSetupTask>() }

npm-publish-gradle-plugin/src/main/kotlin/task/NpmExecTask.kt

@@ -41,5 +41,5 @@ public abstract class NpmExecTask : NodeExecTask() {
    * @return execution result
    */
   public fun npmExec(args: Collection<String?>, config: Action<ExecSpec> = Action {}): ExecResult =
-    exec(listOf(npm.get().asFile.absolutePath) + args, config)
+    nodeExec(listOf(npm.get().asFile.absolutePath) + args, config)
 }

sandbox/empty/build.gradle.kts

@@ -1,6 +1,11 @@
 plugins {
   id("kmp")
   id("dev.petuska.npm.publish")
+  id("com.github.node-gradle.node") version "7.1.0"
+}
+
+repositories {
+  mavenCentral()
 }
 
 kotlin {
@@ -20,6 +25,10 @@ kotlin {
   }
 }
 
+node {
+  download = true
+}
+
 npmPublish {
   organization = group.toString()