Refactor datetime arithmetics #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
refactor-datetime-arithmetics
branch
from
35b6094 to
8567384
Compare
dkhalanskyjb
force-pushed
the
refactor-datetime-arithmetics
branch
from
8567384 to
cf1825e
Compare
dkhalanskyjb
force-pushed
the
refactor-datetime-arithmetics
branch
from
cf1825e to
25a3465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the datetime arithmetic operations to the common code and remove the
ZonedDateTimeabstraction from their implementation.This is supposed to be a refactoring, that is, it preserves the current behavior. The next step is fixing #488, #487, #484, and possibly some other issues.