Skip to content

Commit 3b64add

Browse files
author
d1jang
committed
Delete pip install support script & use a manual tag for update dockerfile.
1 parent fc69038 commit 3b64add

File tree

3 files changed

+5
-70
lines changed

3 files changed

+5
-70
lines changed

Dockerfile

+1-11
Original file line numberDiff line numberDiff line change
@@ -521,14 +521,4 @@ ENV PYTHONUSERBASE "/root/.local"
521521
ADD patches/sitecustomize.py /root/.local/lib/python3.6/site-packages/sitecustomize.py
522522

523523
# Set backend for matplotlib
524-
ENV MPLBACKEND "agg"
525-
526-
# Set up an initialization script to be executed before any other commands initiated by the user.
527-
ADD patches/entrypoint.sh /root/entrypoint.sh
528-
RUN chmod +x /root/entrypoint.sh
529-
# NOTE: ENTRYPOINT set by "FROM <image>" should preceed the our own custom entrypoint.
530-
# Currently tini is set as ENTRYPOINT for the base image, and it can be combined with our entrypoint (https://github.com/krallin/tini).
531-
# ENTRYPOINT gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
532-
# Make sure tini exists.
533-
RUN /usr/bin/tini -h > /dev/null
534-
ENTRYPOINT ["/usr/bin/tini", "--", "/root/entrypoint.sh"]
524+
ENV MPLBACKEND "agg"

kaggle_tools_update.Dockerfile

+4-15
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,12 @@
99
# is enabled.
1010

1111
# Usage:
12-
# docker rmi gcr.io/kaggle-images/python:latest
12+
# docker rmi gcr.io/kaggle-images/python:pinned
1313
# docker build --rm -t kaggle/python-build -f kaggle_tools_update.Dockerfile .
1414
# ./test
1515
# ./push (if tests are passing)
1616

17-
FROM gcr.io/kaggle-images/python:latest
17+
# Pull the last build manually tagged as "pinned".
18+
FROM gcr.io/kaggle-images/python:pinned
1819

19-
RUN pip install --upgrade git+https://github.com/Kaggle/learntools
20-
21-
# TODO(dsjang): Remove these lines once the docker image build turns green since they are copied from Dockerfile
22-
# to apply on top of the last green.
23-
# Set up an initialization script to be executed before any other commands initiated by the user.
24-
ADD patches/entrypoint.sh /root/entrypoint.sh
25-
RUN chmod +x /root/entrypoint.sh
26-
# NOTE: ENTRYPOINT set by "FROM <image>" should preceed the our own custom entrypoint.
27-
# Currently tini is set as ENTRYPOINT for the base image, and it can be combined with our entrypoint (https://github.com/krallin/tini).
28-
# ENTRYPOINT gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
29-
# Make sure tini exists.
30-
RUN /usr/bin/tini -h > /dev/null
31-
ENTRYPOINT ["/usr/bin/tini", "--", "/root/entrypoint.sh"]
20+
RUN pip install --upgrade git+https://github.com/Kaggle/learntools

patches/entrypoint.sh

-44
This file was deleted.

0 commit comments

Comments
 (0)