Skip to content

Commit c4fb5fe

Browse files
committed
Merge pull request #209 from skwashd/memberships-api
Switch from deprecated team member API to team memberships API
2 parents eac0ecc + dc6208a commit c4fb5fe

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/Github/Api/Organization/Teams.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,17 @@ public function members($team)
6060

6161
public function check($team, $username)
6262
{
63-
return $this->get('teams/'.rawurlencode($team).'/members/'.rawurlencode($username));
63+
return $this->get('teams/'.rawurlencode($team).'/memberships/'.rawurlencode($username));
6464
}
6565

6666
public function addMember($team, $username)
6767
{
68-
return $this->put('teams/'.rawurlencode($team).'/members/'.rawurlencode($username));
68+
return $this->put('teams/'.rawurlencode($team).'/memberships/'.rawurlencode($username));
6969
}
7070

7171
public function removeMember($team, $username)
7272
{
73-
return $this->delete('teams/'.rawurlencode($team).'/members/'.rawurlencode($username));
73+
return $this->delete('teams/'.rawurlencode($team).'/memberships/'.rawurlencode($username));
7474
}
7575

7676
public function repositories($team)

test/Github/Tests/Api/Organization/TeamsTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function shouldCheckIfMemberIsInOrganizationTeam()
3232
$api = $this->getApiMock();
3333
$api->expects($this->once())
3434
->method('get')
35-
->with('teams/KnpWorld/members/l3l0')
35+
->with('teams/KnpWorld/memberships/l3l0')
3636
->will($this->returnValue($expectedValue));
3737

3838
$this->assertEquals($expectedValue, $api->check('KnpWorld', 'l3l0'));
@@ -96,7 +96,7 @@ public function shouldAddTeamMembers()
9696
$api = $this->getApiMock();
9797
$api->expects($this->once())
9898
->method('put')
99-
->with('teams/KnpWorld/members/l3l0')
99+
->with('teams/KnpWorld/memberships/l3l0')
100100
->will($this->returnValue($expectedValue));
101101

102102
$this->assertEquals($expectedValue, $api->addMember('KnpWorld', 'l3l0'));
@@ -112,7 +112,7 @@ public function shouldRemoveTeamMembers()
112112
$api = $this->getApiMock();
113113
$api->expects($this->once())
114114
->method('delete')
115-
->with('teams/KnpWorld/members/l3l0')
115+
->with('teams/KnpWorld/memberships/l3l0')
116116
->will($this->returnValue($expectedValue));
117117

118118
$this->assertEquals($expectedValue, $api->removeMember('KnpWorld', 'l3l0'));

0 commit comments

Comments
 (0)