Merge pull request #78 from KnpLabs/feature/rawurlencodefix

rawurlencode instead of urlencode, fixes #77

Author: Evgeniy Guseletov

lib/Github/Api/Authorizations.php

@@ -18,7 +18,7 @@ public function all()
 
     public function show($number)
     {
-        return $this->get('authorizations/'.urlencode($number));
+        return $this->get('authorizations/'.rawurlencode($number));
     }
 
     public function create(array $params)
@@ -28,16 +28,16 @@ public function create(array $params)
 
     public function update($id, array $params)
     {
-        return $this->patch('authorizations/'.urlencode($id), $params);
+        return $this->patch('authorizations/'.rawurlencode($id), $params);
     }
 
     public function remove($id)
     {
-        return $this->delete('authorizations/'.urlencode($id));
+        return $this->delete('authorizations/'.rawurlencode($id));
     }
 
     public function check($id, $token)
     {
-        return $this->get('authorizations/'.urlencode($id).'/tokens/'.urlencode($token));
+        return $this->get('authorizations/'.rawurlencode($id).'/tokens/'.rawurlencode($token));
     }
 }

lib/Github/Api/CurrentUser/DeployKeys.php

@@ -31,7 +31,7 @@ public function all()
      */
     public function show($id)
     {
-        return $this->get('user/keys/'.urlencode($id));
+        return $this->get('user/keys/'.rawurlencode($id));
     }
 
     /**
@@ -68,7 +68,7 @@ public function update($id, array $params)
             throw new MissingArgumentException(array('title', 'key'));
         }
 
-        return $this->patch('user/keys/'.urlencode($id), $params);
+        return $this->patch('user/keys/'.rawurlencode($id), $params);
     }
 
     /**
@@ -80,6 +80,6 @@ public function update($id, array $params)
      */
     public function remove($id)
     {
-        return $this->delete('user/keys/'.urlencode($id));
+        return $this->delete('user/keys/'.rawurlencode($id));
     }
 }

lib/Github/Api/CurrentUser/Followers.php

@@ -33,7 +33,7 @@ public function all($page = 1)
      */
     public function check($username)
     {
-        return $this->get('user/following/'.urlencode($username));
+        return $this->get('user/following/'.rawurlencode($username));
     }
 
     /**
@@ -45,7 +45,7 @@ public function check($username)
      */
     public function follow($username)
     {
-        return $this->put('user/following/'.urlencode($username));
+        return $this->put('user/following/'.rawurlencode($username));
     }
 
     /**
@@ -57,6 +57,6 @@ public function follow($username)
      */
     public function unfollow($username)
     {
-        return $this->delete('user/following/'.urlencode($username));
+        return $this->delete('user/following/'.rawurlencode($username));
     }
 }

lib/Github/Api/CurrentUser/Notifications.php

@@ -33,7 +33,7 @@ public function all(array $params = array())
      */
     public function allInRepository($username, $repository, array $params = array())
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/notifications', $params);
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/notifications', $params);
     }
 
     /**
@@ -57,7 +57,7 @@ public function markAsReadAll(array $params = array())
      */
     public function markAsReadInRepository($username, $repository, array $params = array())
     {
-        return $this->put('repos/'.urlencode($username).'/'.urlencode($repository).'/notifications', $params);
+        return $this->put('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/notifications', $params);
     }
 
     /**
@@ -69,7 +69,7 @@ public function markAsReadInRepository($username, $repository, array $params = a
      */
     public function markAsRead($id, array $params)
     {
-        return $this->patch('notifications/threads/'.urlencode($id), $params);
+        return $this->patch('notifications/threads/'.rawurlencode($id), $params);
     }
 
     /**
@@ -80,7 +80,7 @@ public function markAsRead($id, array $params)
      */
     public function show($id)
     {
-        return $this->get('notifications/threads/'.urlencode($id));
+        return $this->get('notifications/threads/'.rawurlencode($id));
     }
 
     /**
@@ -91,7 +91,7 @@ public function show($id)
      */
     public function showSubscription($id)
     {
-        return $this->get('notifications/threads/'.urlencode($id).'/subscription');
+        return $this->get('notifications/threads/'.rawurlencode($id).'/subscription');
     }
 
     /**
@@ -103,7 +103,7 @@ public function showSubscription($id)
      */
     public function createSubscription($id, array $params)
     {
-        return $this->put('notifications/threads/'.urlencode($id).'/subscription', $params);
+        return $this->put('notifications/threads/'.rawurlencode($id).'/subscription', $params);
     }
 
     /**
@@ -114,6 +114,6 @@ public function createSubscription($id, array $params)
      */
     public function removeSubscription($id)
     {
-        return $this->delete('notifications/threads/'.urlencode($id).'/subscription');
+        return $this->delete('notifications/threads/'.rawurlencode($id).'/subscription');
     }
 }

lib/Github/Api/CurrentUser/Watchers.php

@@ -34,7 +34,7 @@ public function all($page = 1)
      */
     public function check($username, $repository)
     {
-        return $this->get('user/watched/'.urlencode($username).'/'.urlencode($repository));
+        return $this->get('user/watched/'.rawurlencode($username).'/'.rawurlencode($repository));
     }
 
     /**
@@ -47,7 +47,7 @@ public function check($username, $repository)
      */
     public function watch($username, $repository)
     {
-        return $this->put('user/watched/'.urlencode($username).'/'.urlencode($repository));
+        return $this->put('user/watched/'.rawurlencode($username).'/'.rawurlencode($repository));
     }
 
     /**
@@ -60,6 +60,6 @@ public function watch($username, $repository)
      */
     public function unwatch($username, $repository)
     {
-        return $this->delete('user/watched/'.urlencode($username).'/'.urlencode($repository));
+        return $this->delete('user/watched/'.rawurlencode($username).'/'.rawurlencode($repository));
     }
 }

lib/Github/Api/Gists.php

@@ -20,12 +20,12 @@ public function all($type = null)
             return $this->get('gists');
         }
 
-        return $this->get('gists/'.urlencode($type));
+        return $this->get('gists/'.rawurlencode($type));
     }
 
     public function show($number)
     {
-        return $this->get('gists/'.urlencode($number));
+        return $this->get('gists/'.rawurlencode($number));
     }
 
     public function create(array $params)
@@ -41,31 +41,31 @@ public function create(array $params)
 
     public function update($id, array $params)
     {
-        return $this->patch('gists/'.urlencode($id), $params);
+        return $this->patch('gists/'.rawurlencode($id), $params);
     }
 
     public function fork($id)
     {
-        return $this->post('gists/'.urlencode($id).'/fork');
+        return $this->post('gists/'.rawurlencode($id).'/fork');
     }
 
     public function remove($id)
     {
-        return $this->delete('gists/'.urlencode($id));
+        return $this->delete('gists/'.rawurlencode($id));
     }
 
     public function check($id)
     {
-        return $this->get('gists/'.urlencode($id).'/star');
+        return $this->get('gists/'.rawurlencode($id).'/star');
     }
 
     public function star($id)
     {
-        return $this->put('gists/'.urlencode($id).'/star');
+        return $this->put('gists/'.rawurlencode($id).'/star');
     }
 
     public function unstar($id)
     {
-        return $this->delete('gists/'.urlencode($id).'/star');
+        return $this->delete('gists/'.rawurlencode($id).'/star');
     }
 }

lib/Github/Api/GitData/Blobs.php

@@ -22,7 +22,7 @@ public function configure($bodyType = null)
 
     public function show($username, $repository, $sha)
     {
-        $response = $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/blobs/'.urlencode($sha));
+        $response = $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/blobs/'.rawurlencode($sha));
 
         return $response;
     }
@@ -33,6 +33,6 @@ public function create($username, $repository, array $params)
             throw new MissingArgumentException(array('content', 'encoding'));
         }
 
-        return $this->post('repos/'.urlencode($username).'/'.urlencode($repository).'/git/blobs', $params);
+        return $this->post('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/blobs', $params);
     }
 }

lib/Github/Api/GitData/Commits.php

@@ -13,7 +13,7 @@ class Commits extends AbstractApi
 {
     public function show($username, $repository, $sha)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/commits/'.urlencode($sha));
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/commits/'.rawurlencode($sha));
     }
 
     public function create($username, $repository, array $params)
@@ -22,6 +22,6 @@ public function create($username, $repository, array $params)
             throw new MissingArgumentException(array('message', 'tree', 'parents'));
         }
 
-        return $this->post('repos/'.urlencode($username).'/'.urlencode($repository).'/git/commits', $params);
+        return $this->post('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/commits', $params);
     }
 }

lib/Github/Api/GitData/References.php

@@ -13,22 +13,22 @@ class References extends AbstractApi
 {
     public function all($username, $repository)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs');
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs');
     }
 
     public function branches($username, $repository)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/heads');
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/heads');
     }
 
     public function tags($username, $repository)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/tags');
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/tags');
     }
 
     public function show($username, $repository, $reference)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/'.urlencode($reference));
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference));
     }
 
     public function create($username, $repository, array $params)
@@ -37,7 +37,7 @@ public function create($username, $repository, array $params)
             throw new MissingArgumentException(array('ref', 'sha'));
         }
 
-        return $this->post('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs', $params);
+        return $this->post('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs', $params);
     }
 
     public function update($username, $repository, $reference, array $params)
@@ -46,11 +46,11 @@ public function update($username, $repository, $reference, array $params)
             throw new MissingArgumentException('sha');
         }
 
-        return $this->patch('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/'.urlencode($reference), $params);
+        return $this->patch('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference), $params);
     }
 
     public function remove($username, $repository, $reference)
     {
-        return $this->delete('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/'.urlencode($reference));
+        return $this->delete('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference));
     }
 }

lib/Github/Api/GitData/Tags.php

@@ -13,12 +13,12 @@ class Tags extends AbstractApi
 {
     public function all($username, $repository)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/refs/tags');
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/tags');
     }
 
     public function show($username, $repository, $sha)
     {
-        return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/git/tags/'.urlencode($sha));
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/tags/'.rawurlencode($sha));
     }
 
     public function create($username, $repository, array $params)
@@ -35,6 +35,6 @@ public function create($username, $repository, array $params)
             throw new MissingArgumentException(array('tagger.name', 'tagger.email', 'tagger.date'));
         }
 
-        return $this->post('repos/'.urlencode($username).'/'.urlencode($repository).'/git/tags', $params);
+        return $this->post('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/tags', $params);
     }
 }