Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBreadcrumbsArray is broken if a label is used twice in a path #47

Closed
stof opened this issue Apr 19, 2012 · 0 comments
Closed

getBreadcrumbsArray is broken if a label is used twice in a path #47

stof opened this issue Apr 19, 2012 · 0 comments
Labels
bug Something isn't working

Comments

@stof
Copy link
Collaborator

stof commented Apr 19, 2012

There is absolutely no constraint about labels in KnpMenu. But while working on #45, I figured that the label is used as key in the return value of getBreadcrumbsArray, meaning the method is totally broken when a label is used twice in a path in the tree.

Fixing it would require a BC break as the bug comes from the design chosen for the method (which still comes from ioMenuPlugin)
@dbu dbu mentioned this issue Apr 20, 2012
Closed
@stof stof closed this as completed in ce6bbaa May 4, 2012
@stof stof reopened this May 4, 2012
@stof stof mentioned this issue May 4, 2012
Merged
@stof stof closed this as completed in 30346c5 May 17, 2012
petesiss pushed a commit to petesiss/KnpMenu that referenced this issue Jun 8, 2012
@stof
Merge pull request KnpLabs#52 from KnpLabs/refactor_breadcrumb_array
1f27b31 
Refactor breadcrumb array

Closes KnpLabs#47
bamarni pushed a commit to bamarni/KnpMenu that referenced this issue Aug 8, 2012
Missing namespace in MenuFactory default item class fix KnpLabs#47
364c933
bamarni pushed a commit to bamarni/KnpMenu that referenced this issue Aug 8, 2012
@mbontemps
Merge pull request KnpLabs#54 from Alveos/patch-1
95abd4d 
Missing namespace in MenuFactory default item class fix KnpLabs#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stof