List: don't memmove when deleting the last entry

Noam Preil · Noam Preil · commit 9f023fcc013b · 2020-09-11T04:36:35.000-04:00
diff --git a/common/list.c b/common/list.c
@@ -49,12 +49,13 @@ void list_insert(list_t *list, int index, void *item) {
 
 void list_del(list_t *list, int index) {
 	list->length--;
-	memmove(&list->items[index], &list->items[index + 1], sizeof(void*) * (list->length - index));
+	if (index != list->length) {
+		memmove(&list->items[index], &list->items[index + 1], sizeof(void*) * (list->length - index));
+	}
 }
 
 void list_cat(list_t *list, list_t *source) {
-	int i;
-	for (i = 0; i < source->length; ++i) {
+	for (int i = 0; i < source->length; ++i) {
 		list_add(list, source->items[i]);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,13 @@ void list_insert(list_t list, int index, void item) {`
`49`	`49`
`50`	`50`	`void list_del(list_t *list, int index) {`
`51`	`51`	`list->length--;`
`52`		`- memmove(&list->items[index], &list->items[index + 1], sizeof(void) (list->length - index));`
	`52`	`+ if (index != list->length) {`
	`53`	`+ memmove(&list->items[index], &list->items[index + 1], sizeof(void) (list->length - index));`
	`54`	`+ }`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`void list_cat(list_t list, list_t source) {`
`56`		`- int i;`
`57`		`- for (i = 0; i < source->length; ++i) {`
	`58`	`+ for (int i = 0; i < source->length; ++i) {`
`58`	`59`	`list_add(list, source->items[i]);`
`59`	`60`	`}`
`60`	`61`	`}`