fix(restoreStateFile): set dataID based on primarySelection

Also fix restoring segment groups

Author: PaulHax

src/io/import/processors/restoreStateFile.ts

@@ -191,13 +191,15 @@ const migrate501To600 = (inputManifest: any) => {
         migratedView.type = 'Oblique';
       }
 
-      // Set dataID based on whether the view has config with data
-      // In 5.0.1, if a view has config entries, it means it's associated with that data
-      if (migratedView.config && Object.keys(migratedView.config).length > 0) {
-        // Use the first (and typically only) key from config as the dataID
-        migratedView.dataID = Object.keys(migratedView.config)[0];
-      } else {
-        migratedView.dataID = null;
+      const configKeys = Object.keys(migratedView.config || {});
+      const primarySelection = manifest.primarySelection;
+
+      migratedView.dataID = null;
+      if (configKeys.length > 0) {
+        migratedView.dataID =
+          primarySelection && configKeys.includes(primarySelection)
+            ? primarySelection
+            : configKeys[0];
       }
 
       manifest.viewByID[migratedView.id] = migratedView;

src/store/view-configs/layers.ts

@@ -27,7 +27,8 @@ function getPreset(id: string) {
   const layersStore = useLayersStore();
   const layer = layersStore.getLayer(id);
   if (!layer) {
-    throw new Error(`Layer ${id} not found`);
+    // Return default preset if layer not found (e.g., for segment groups)
+    return LAYER_PRESET_DEFAULT;
   }
 
   if (isDicomImage(layer.selection)) {

tests/specs/state-manifest.e2e.ts

@@ -30,17 +30,23 @@ async function openVolViewPage(fileName: string) {
 
   // Check that no placeholder overlays are visible (mdi-image-off icons)
   // The overlays are in divs that are shown/hidden based on imageID
-  const visibleOverlayCount = await browser.execute(() => {
-    const imageOffIcons = document.querySelectorAll('i.mdi-image-off');
-    return Array.from(imageOffIcons).filter((icon) => {
-      const parent = icon.closest('div.overlay');
-      if (!parent) return false;
-      const style = window.getComputedStyle(parent);
-      return style.display !== 'none' && style.visibility !== 'hidden';
-    }).length;
-  });
-
-  expect(visibleOverlayCount).toEqual(0);
+  await browser.waitUntil(
+    async () => {
+      const visibleOverlayCount = await browser.execute(() => {
+        const imageOffIcons = document.querySelectorAll('i.mdi-image-off');
+        return Array.from(imageOffIcons).filter((icon) => {
+          const parent = icon.closest('div.overlay');
+          if (!parent) return false;
+          const style = window.getComputedStyle(parent);
+          return style.display !== 'none' && style.visibility !== 'hidden';
+        }).length;
+      });
+      return visibleOverlayCount === 0;
+    },
+    {
+      timeoutMsg: 'Image placeholder overlays are still visible',
+    }
+  );
 }
 
 describe('State file manifest.json code', () => {
@@ -54,10 +60,25 @@ describe('State file manifest.json code', () => {
     await openVolViewPage(fileName);
   });
 
-  it('has no errors loading manifest with axial layer layout', async () => {
+  it('loads 5.0.1 manifest with axial layer layout', async () => {
     const manifestPath = path.join(FIXTURES, 'layer-axial.5-0-1.volview.json');
     const fileName = 'temp-layer-axial.volview.zip';
     await writeManifestToZip(manifestPath, fileName);
     await openVolViewPage(fileName);
+
+    // Switch to the Rendering tab
+    const renderingTab = await $('button[data-testid="module-tab-Rendering"]');
+    await renderingTab.click();
+
+    // Wait for and verify that the layer opacity slider is visible
+    await browser.waitUntil(
+      async () => {
+        const layerSlider = await $('[data-testid="layer-opacity-slider"]');
+        return layerSlider.isDisplayed();
+      },
+      {
+        timeoutMsg: 'Layer opacity slider is not visible in the Rendering tab',
+      }
+    );
   });
 });

wdio.shared.conf.ts

@@ -7,7 +7,7 @@ export const WINDOW_SIZE = [1200, 800] as const;
 export const TEST_PORT = 4567;
 // for slow connections try:
 // DOWNLOAD_TIMEOUT=60000 && npm run test:e2e:dev
-export const DOWNLOAD_TIMEOUT = Number(process.env.DOWNLOAD_TIMEOUT ?? 30000);
+export const DOWNLOAD_TIMEOUT = Number(process.env.DOWNLOAD_TIMEOUT ?? 60000);
 
 const ROOT = projectRoot();
 const TMP = '.tmp/';