Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the Share Link feature #5227

Closed
5 tasks done
pierremtb opened this issue Feb 3, 2025 · 5 comments · Fixed by #5228
Closed
5 tasks done

Release the Share Link feature #5227

pierremtb opened this issue Feb 3, 2025 · 5 comments · Fixed by #5228
Assignees
Labels
enhancement New feature or request

Comments

@pierremtb
Copy link
Collaborator

pierremtb commented Feb 3, 2025

Follow up to #4166 and #4088

Tasks

Preview Give feedback
  1. pierremtb
  2. pierremtb
@pierremtb pierremtb added the enhancement New feature or request label Feb 3, 2025
@pierremtb
Copy link
Collaborator Author

@franknoirot For the record I was able to take a build from https://github.com/KittyCAD/modeling-app/actions/runs/13116420540 (merge to main) and run through the flow with https://app.dev.zoo.dev on macOS

Let's list up there other things we might need before releasing it to in a versioned build.

pierremtb added a commit that referenced this issue Feb 3, 2025
pierremtb added a commit that referenced this issue Feb 7, 2025
@pierremtb
Copy link
Collaborator Author

With the fixes in #5304, we're now only waiting on nightly testing with more people to release it with #5228

@jessfraz
Copy link
Contributor

jessfraz commented Feb 7, 2025

other things we might want to track after that which ill let yall decide where this lives:

@pierremtb
Copy link
Collaborator Author

pierremtb commented Feb 11, 2025

Ok so on v42 the share link command is disabled in the UI but it exists in the command bar (shouldn't be, that's a bug, but not so important considering how buried that is). Just tested on macOS, Windows, and Linux and it worked across all for me.

There is definitely a reproducible second-instance multiple second lag on opening across OSes, will file a separate bug for this. We need the requestSingleInstance lock thing we discussed on Slack some time ago with @nadr0

Edit: separate bug: #5346

@pierremtb
Copy link
Collaborator Author

pierremtb commented Feb 11, 2025

@jessfraz @franknoirot both of those can live directly on the website and in text-to-cad ui, from my testing it's good to take in zoo-studio:// calls on any platform (edit: with the bug listed above to fix for best experience)

We should create issues in these repos before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants