Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocompletions in lsp for settings annotation #5204

Closed
jessfraz opened this issue Jan 31, 2025 · 8 comments
Closed

autocompletions in lsp for settings annotation #5204

jessfraz opened this issue Jan 31, 2025 · 8 comments
Assignees
@nrc
Labels
kcl Language and compiler features lsp Issues / features relevant to the lsp server.
Milestone
v1 Modeling App L...

Comments

@jessfraz
Copy link
Contributor

No description provided.

@jessfraz jessfraz added kcl Language and compiler features lsp Issues / features relevant to the lsp server. labels Jan 31, 2025
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Jan 31, 2025
@jessfraz
Copy link
Contributor Author

maybe some syntax highlighting too? idk up to you

@jtran
Copy link
Collaborator

jtran commented Feb 4, 2025

@mattmundell, FYI, we have new syntax for annotations, which we're using for units. CodeMirror highlighting hasn't been done yet.

@mattmundell
Copy link
Contributor

Sounds like a fun task for me. Will take a look later this week, if it's still open.

@mattmundell
Copy link
Contributor

mattmundell commented Feb 7, 2025 •
edited
Loading

@jtran If this is about named fn args then /pull/5299 updates the grammar.

If you want highlighting, I have a small patch that needs 5299. Eg below it highlights endAbsolute, plane (inside planeBottomSide) and origin:
Image
Useful, I would say.

@jtran
Copy link
Collaborator

jtran commented Feb 7, 2025

I didn't realize we weren't highlighting keyword arguments yet. Yes, that is a prerequisite to annotations.

@mattmundell
Copy link
Contributor

Ah you're talking about @settings. I'll add parsing so it can be highlighted.

@mattmundell mattmundell mentioned this issue Feb 11, 2025
Closed
@jtran jtran mentioned this issue Feb 13, 2025
Merged
@jessfraz
Copy link
Contributor Author

@nrc did this

@jtran
Copy link
Collaborator

jtran commented Mar 28, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrc nrc

Labels
kcl Language and compiler features lsp Issues / features relevant to the lsp server.
Projects
None yet
Milestone
v1 Modeling App Launch
Development

No branches or pull requests
4 participants
@jtran @nrc @jessfraz @mattmundell