Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grackle: port stdlib #1727

Closed
32 of 68 tasks
adamchalmers opened this issue Mar 14, 2024 · 8 comments
Closed
32 of 68 tasks

Grackle: port stdlib #1727

adamchalmers opened this issue Mar 14, 2024 · 8 comments

Comments

@adamchalmers
Copy link
Collaborator

adamchalmers commented Mar 14, 2024

The current executor supports around 66 stdlib calls. Currently, only startSketchAt, extrude, close and lineTo have been ported to Grackle. Port the rest.

@lf94 lf94 assigned lf94 and unassigned lf94 Mar 15, 2024
@lf94
Copy link
Contributor

lf94 commented Mar 18, 2024

Note to self:

@lf94
Copy link
Contributor

lf94 commented Mar 21, 2024

NOTE: I must call toRadians on the Grackle backend for all trig functions...

@jessfraz
Copy link
Contributor

The reason why I have those functions as radians is I could not find a popular programming language where they were not radians, meaning any ai model and human is going to assume they are radians, if we are the outlier its unintuitive

@lf94
Copy link
Contributor

lf94 commented Mar 21, 2024

Oh so we want cos and sin, etc to remain radians? Because that's 100% what I want lol, but I know we have the whole "default to degrees" thing.

That's perfect then. I'll just do it in the functions that take an angle argument!

@jessfraz
Copy link
Contributor

These functions are the exception since it’s unintuitive

@jessfraz
Copy link
Contributor

Make them work like the current stdlib which is radians

@alteous
Copy link

alteous commented Mar 22, 2024

atan2 is important too.

@jessfraz
Copy link
Contributor

We are only porting the current stdlib adding new functions can be outside this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants