Skip to content

Folia??? #4

@mbax

Description

@mbax

Before opening a PR for this, please read the following:

5.x is where I'll be okay with folia support. The place to start is adding folia support to TaskChain to support tying a task to an entity.

However, if someone wishes to insist on writing a PR for 4.x, the following applies:

  • The PR needs to account for multiple players attempting to access vaults at the same time, via any command, sign, or API.
  • The PR needs to ensure that there's no way to have race conditions or deadlocks as result of either the current code or a result of changes to try to make it support folia.

Thus far there have been two rejected pull requests that just attempted to slap a scheduler change onto the plugin. This is bad, and shows a lack of understanding of what Folia does. Further PRs like these will be immediately closed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    For 5.1+

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions