Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]:avatar loader + placeholder #39

Open
sambitraze opened this issue Oct 2, 2020 · 6 comments · May be fixed by #54
Open

[BUG]:avatar loader + placeholder #39

sambitraze opened this issue Oct 2, 2020 · 6 comments · May be fixed by #54
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@sambitraze
Copy link
Collaborator

sambitraze commented Oct 2, 2020 •
edited by Cryptonex7
Loading

Describe the bug

There is just a white space befoere the avatar is loaded at app drawer.

Expected behavior

Need of a placeholder + loader for avatar while being fetched from internet in the drawer

Proposed Solution

add loader and placeholder

Screenshot

bug1
@sambitraze sambitraze added bug Something isn't working help wanted Extra attention is needed labels Oct 2, 2020
@Abhijeet-sonkar
Copy link

Can I work on this issue?

@Cryptonex7
Copy link
Member

Sure @Abhijeet-sonkar we would love you to contribute to this repo.

@Abhijeet-sonkar
Copy link

Can you provide a test/guest login ID and password so that I can test the app?

@Cryptonex7
Copy link
Member

@Abhijeet-sonkar,

I am afraid that we cannot provide you with credentials. This is the only issue which requires a student specifically studying in KIIT University, Bhubaneshwar, India.

There are a few ways to handle this situation:

  • Submit the PR, and the reviewers can test it for you.
  • If you have friends in KIIT, you might take their help.
  • All the other issues in this repository are generic and could be taken up by anybody in the world.

We are sorry for the inconvenience, we understand, that we should've mentioned this issue as "KIIT only".

We request you to manage it this time, and We assure you that this will be taken care of in future.

@Cryptonex7 Cryptonex7 added the KIIT-ONLY Only KIIT students can resolve this issue, as this issue requires student credentials. label Oct 3, 2020
@Cryptonex7
Copy link
Member

@Abhijeet-sonkar However, if you are asking for guest credentials of the entire app, then you can just signup for it.

The only areas restricted for KIIT students is the Attendance Page and the SAP WebView.

@Cryptonex7 Cryptonex7 removed the KIIT-ONLY Only KIIT students can resolve this issue, as this issue requires student credentials. label Oct 4, 2020
@jordanmlacalle
Copy link

@Cryptonex7 I have a proposed solution depicted here:

ezgif-6-4394705c2a2d

@jordanmlacalle jordanmlacalle linked a pull request Oct 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add blank avatar placeholder. Precache on startup for performance jordanmlacalle/Kide
4 participants
@sambitraze @jordanmlacalle @Cryptonex7 @Abhijeet-sonkar