Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to project component to shield against regression #20

Open
NickLewanowicz opened this issue Jul 17, 2018 · 0 comments
Open

Add tests to project component to shield against regression #20

NickLewanowicz opened this issue Jul 17, 2018 · 0 comments
Assignees
Labels
testing Tests need to be written or existing tests need to be edited

Comments

@NickLewanowicz
Copy link
Member

Expected Behavior

When pr#6 went through we fixed the re-render issues that caused empty lists to be rendered. We should have some tests to protect against regression of this issue.

Current Behavior

No tests were added with pr#6 but we should add some

Possible Solution

We currently use Jest as a testing framework, we should implement a testing directory for components where we test particular components individually.

Possible Implementation

  1. Add a directory in testing for component tests
  2. make a file with name related to project.js
  3. Implement snapshot tests to make sure the list renders with some data
@NickLewanowicz NickLewanowicz added the testing Tests need to be written or existing tests need to be edited label Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests need to be written or existing tests need to be edited
Projects
None yet
Development

No branches or pull requests

2 participants