Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some released .dotfiles create issues when managing the plugin with git #350

Open
pedro-mendonca opened this issue Feb 26, 2025 · 7 comments · May be fixed by #351
Open

Some released .dotfiles create issues when managing the plugin with git #350

pedro-mendonca opened this issue Feb 26, 2025 · 7 comments · May be fixed by #351

Comments

@pedro-mendonca
Copy link

Thanks for this great plugin :)

While managing plugin updates through git, I've found a problem.

The plugin released in WordPress.org includes development files.

For example, the .gitignore prevents to upload the build subfolder, that is essencial for the plugin to be used.

The .gitignore is important to the Git repo, but it's better to not deploy it to .org.

@KevinBatdorf
Copy link
Owner

I can remove it, but can you detail a bit more how it's affecting you?

@pedro-mendonca
Copy link
Author

Hi, sure.
While managing a site updates through Git, by actually including all the plugins code, the .gitignore that code-block-pro has to disallow including local build files in your repo, which is correct, as this file is also included in the released plugin, it blocks the Git to include the same build files.
These files are essencial, and included in the relased plugin, but the existing .gitignore is preventing the site Git repo to use them. It's generally a best-practice to not include the dev files in the release, and this is a case where it's really is a road blocker :)

pedro-mendonca added a commit to pedro-mendonca/code-block-pro that referenced this issue Feb 26, 2025
@pedro-mendonca pedro-mendonca linked a pull request Feb 26, 2025 that will close this issue
@pedro-mendonca
Copy link
Author

I've suggested the PR #351 to fix this :)
Feel free to not use it, please take this as a suggestion.

@KevinBatdorf
Copy link
Owner

Well, I generally want to keep the dev files on the w.org svn repo as it's essentially an archive of open source, and educational. The .gitignore isn't particularly important to include though

it blocks the Git to include the same build files.

Can you explain this a bit more and how it affects you? Is it breaking something?

@pedro-mendonca
Copy link
Author

Can you explain this a bit more and how it affects you? Is it breaking something?

Is preventing including the /build files in a site where the plugin versions are maintained through Git. I guess not using the /build files will break functionality.

@KevinBatdorf
Copy link
Owner

Ah, so you're checking in plugins into git? I'd suggest using composer to manage them if possible rather than tracking them. Regardless, we can remove the .gitignore file from the plugin

@pedro-mendonca
Copy link
Author

Yes, I understand, using composer is a good alternative, still not viable for all situations.
Thank you for your care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants