Skip to content

get_dataset() doesn't require context_length, but the TatmMemmapDataset constructor does #96

@toizzy

Description

@toizzy

get_dataset calls TatmMemmapDataset() with **kwargs, and errors when optional argument context_length is missing

>>> from tatm.data import get_dataset, torch_collate_fn
>>> get_dataset("/dolma_path/dolma/tokenized/baseten-meta-llama-3-tokenizer/c4")                                                                                                                  
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/conda_env/lib/python3.12/site-packages/tatm/data/datasets.py", line 49, in get_dataset                                                                                                 
    return TatmMemmapDataset(
           ^^^^^^^^^^^^^^^^^^
TypeError: TatmMemmapDataset.__init__() missing 1 required positional argument: 'context_length'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions