Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong implementation of 'add' and 'paste' url commands #7

Open
KarstenSchulz opened this issue Jul 21, 2020 · 1 comment
Open

Wrong implementation of 'add' and 'paste' url commands #7

KarstenSchulz opened this issue Jul 21, 2020 · 1 comment
Assignees
@KarstenSchulz
Labels
bug

Comments

@KarstenSchulz
Copy link
Owner

In urlhelper.url() if self.in_project is not None, the url will automatically become a paste url (twodo://x-callback-url/paste?...) instead of an add url (twodo://x-callback-url/add?...). This behavior is wrong. The decision for a paste- or an add-url should be intentionally made by the caller via a call argument like url_type=TwoDoTask.ADD_URL or url_type=TwoDoTask.PASTE_URL.
@KarstenSchulz KarstenSchulz self-assigned this Jul 21, 2020
@KarstenSchulz
Copy link
Owner Author

Will be an update which brakes compatibility. So it will be implemented in the next major version (1.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KarstenSchulz KarstenSchulz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KarstenSchulz