-
Notifications
You must be signed in to change notification settings - Fork 5
Prepare the arrival of UBI 10 and do a lot of Spring cleaning #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Chances are it will be the first version fully vetted for Quarkus
I think we really need to push a list of compatible runtimes when adding a new UBI version, instead of relying on brittle exclusions.
Also prepare the arrival of UBI 10 testing.
|
Hmmm, apparently, given the CI matrix, there are additional CI files that require my attention. I'll have a closer look tomorrow. |
Also drop all the now irrelevant patches.
0082a42 to
12398c6
Compare
|
@Karm I see one test failing: I have been trying to start the app locally and AFAICS the content is here when started locally so I'm not sure what is going on. |
|
Hello @gsmet, thank you for visiting us at the Mandrel Integration Testsuite venue :-) I went over the commits and we do not need these changes at this time except this one:
I like that change a lot and we would like to have it and backport it to the branch https://github.com/Karm/mandrel-integration-tests/tree/testing-more-runtime-images that is used to run tests over at https://github.com/quarkusio/quarkus-images |
|
@gsmet Thanks for looking into the TS. At this moment, I would like to close this PR unmerged and if there are mode UBI10 adjustments needed, I'd do those in #386. I do realize the versioning scheme etc. is confusing and we should do a much better job on the README or CONTRIBUTING docs, e.g. for starters explaining what is this TS actually used for and where. The destiny of the 6 commits in this PR is as follows:
|

I wasn't able to test everything as some testing requires sudo for whatever reason so let's see how CI likes it.
This is to prepare the arrival of UBI 10 images: quarkusio/quarkus-images#313. I started by wanting some test coverage for UBI 10 and this is how it ended up :).
I took Quarkus 3.20 as the new base, which allowed to simplify a lot of stuff.
Note that commits are semantic and should be reviewed one by one.