fix(router): make wrapScreen public for RouterView compatibility (Closes #1928)#1940
fix(router): make wrapScreen public for RouterView compatibility (Closes #1928)#1940madhuri-perumalla wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe private ChangeswrapScreen API rename
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks — the Issue:
Checklist before re-requesting review:
|
Description
This PR resolves the remaining API mismatch between
RouterandRouterViewby exposingwrapScreen()as a public Router API.Previously,
RouterViewrelied on the private_wrapScreen()method, which caused TypeScript build failures due to access of a private member. This change introduces a publicwrapScreen()method and updates internal references to use the public API.Related Issue
Closes #1928
Which package(s)?
Type of Change
type:bug)Checklist
bun vitest runbun run buildbun run typecheckCONTRIBUTING.md.type: short description.markDirty()(if applicable).anytypes without an inline comment explaining why.GSSoC 2026 Participation
Notes for the Reviewer
The
autoUnmountproperty anddirectionfield onNavigateEventare already present in the currentmainbranch. This PR focuses only on exposingwrapScreen()as a public API and updating all internal usages accordingly, providing a minimal, backward-compatible fix for the remaining API mismatch reported in Issue #1928.Summary by CodeRabbit