Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room ID shouldn't have spaces #162

Open
abhigyank opened this issue Oct 31, 2020 · 4 comments
Open

Room ID shouldn't have spaces #162

abhigyank opened this issue Oct 31, 2020 · 4 comments

Comments

@abhigyank
Copy link
Member

In the current implementation we give the room name as the id of the room element. But incase the room name has spaces the room id is then set with spaces, which wrong. So when there are space in the room name, the room id should be set with the spaces being replaced with - . If the room name is Hello World, id should be Hello-World .

This is a critical change as room id is being used a lot of places and the change should ensure that nothing gets broken.

@sesamechicken
Copy link
Collaborator

@abhigyank You could replace the with a - client-side so that room names are human-readable and don't require validation on room creation. My 2 cents

@abhigyank
Copy link
Member Author

@sesamechicken I think that's something the backend should handle ideally. Because if a user creates a room with and we show them it replaced with -, it's not good UX.

@sesamechicken
Copy link
Collaborator

I think I didn't communicate it correctly:

The user should be able to create a room with spaces. You can, in the front end code, set the ID's as the room name with the spaces replaced with dashes so you have qualified selectors. Does that make sense?

@abhigyank
Copy link
Member Author

Yes you're right @sesamechicken . That's exactly what needs to be done in this issue.

@LalitNM LalitNM added the urgent must be fixed quickly label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants