[BUG] WebSocketRoute not working properly

[josegrobles]

System info

• Playwright Version: 1.49.1
• Operating System: All
• Browser: Chrome

Source code

const { chromium } = require('patchright');

(async () => {
  const browser = await chromium.launch({
    headless: false,
    viewport: null,
    channel: 'chrome',
  });
  const context = await browser.newContext();
  const page = await context.newPage();
  await page.routeWebSocket(() => true, ws => {
    const server = ws.connectToServer();
    ws.onMessage(message => {
      console.log('sent',message);
      server.send(message);
    });
    server.onMessage(message => {
      console.log('received',message);
      ws.send(message);
    });
  });

  await page.goto('https://www.olybet.ee/sports/live');
})();

• I provided exact source code that allows reproducing the issue locally.

Steps

• Run the provided Script

Expected

Logs all the messages from WebSocket connections on the current page.

Actual

Nothing is logged. If you try with the regular Playwright it works properly.

[ramsestom]

WebSocketRoute rely on bindings through Runtime.addBinding to transmit the websocket messages received from a server and captured/modified by the webSocketMock injected proxy (injected with an InitScript on each page) back to playwright. As patchright removed all Runtime.enable calls from the playwright code, I think this might be the issue if bindings created by calls to the Runtime domain have to have that domain enabled to work

[kaliiiiiiiiii]

injected proxy (injected with an InitScript on each page)

I believe removing this is intentional, since applying JS proxies is genrally detectable. The way to go here would be to use a mitmproxy. Eg. smth compareable to https://github.com/ulixee/hero/blob/2ef172222db080368a0897e3eac39fa91c6598fe/agent/docs/Man-in-the-Middle.md

I guess this is in our TODO's at some point - but probably not any near time.

[ramsestom]

I believe removing this is intentional, since applying JS proxies is genrally detectable.

The whole playwright api is an injected JS script. Locators all run with a JS script injected by playwright on every page for example. So the JS webSocketMock proxy isn't the only JS playwright inject to work.

[kaliiiiiiiiii]

I believe removing this is intentional, since applying JS proxies is genrally detectable.

The whole playwright api is an injected JS script. Locators all run with a JS script injected by playwright on every page for example. So the JS webSocketMock proxy isn't the only JS playwright inject to work.

Here it is, actually, since patchright executes all other stuff in an isolated world