Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ModulePartVariants delete transforms in flight scene? #253

Open
JonnyOThan opened this issue Sep 26, 2024 · 0 comments
Open

Should ModulePartVariants delete transforms in flight scene? #253

JonnyOThan opened this issue Sep 26, 2024 · 0 comments
Labels
kspPerformance Possible performance improvement in KSP

Comments

@JonnyOThan
Copy link
Contributor

I've been looking into Waterfall performance lately, and one of the issues is that it does a lot of work for GameObjects that are inactive because of ModulePartVariants. Is there any reason that ApplyVariant shouldn't just outright delete these objects if you're in the flight scene?
@JonnyOThan JonnyOThan added the kspPerformance Possible performance improvement in KSP label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kspPerformance Possible performance improvement in KSP
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonnyOThan