Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to pin workflow/action versions #21

Open
JonnyOThan opened this issue Aug 13, 2024 · 2 comments
Open

Find a way to pin workflow/action versions #21

JonnyOThan opened this issue Aug 13, 2024 · 2 comments
Labels
github-actions Relates to github actions and workflows

Comments

@JonnyOThan
Copy link
Contributor

Since workflows and actions call each other, it makes this difficult. We may need to have them check out the .github directory somewhere locally at the pinned ref and operate on local paths.

While I’d like to be able to support mods that don’t have kspbuildtools as a submodule, I think I’d also be ok with requiring that if you wanted to pin the workflow versions.

But all the major actions out there support pinning for reusable workflows - how do they do it? Do we just create a branch for each release and replace all the refs…?

@JonnyOThan JonnyOThan added the github-actions Relates to github actions and workflows label Aug 15, 2024
@Twinki14
Copy link
Contributor

Twinki14 commented Aug 31, 2024

I'd suggest separating them into different repositories,

KSPModdingLibs/actions for all re-usable actions
KSPModdingLibs/workflows for all re-usable workflows

Whenever you cut a release in those repositories, write a workflow that updates a major version tag with the release. I can help with this if needed.

That's how for example actions have @v3, so you would have @KSPModdingLibs/actions/[email protected] or @KSPModdingLibs/actions/publish-spacedock@v3

@drewcassidy
Copy link
Member

https://github.com/dariocurr/checkout-called this is worth looking at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Relates to github actions and workflows
Development

No branches or pull requests

3 participants