Skip to content

Commit b85c629

Browse files
authored
Merge pull request #417 from KEEPER31337/feature/세미나_출석_정보_조회시_이름_정렬_추가
Feature/세미나 출석 정보 조회시 기수와 이름 정렬을 추가한다.
2 parents b6e1082 + 550782c commit b85c629

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

src/main/java/com/keeper/homepage/domain/seminar/api/SeminarAttendanceController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import lombok.RequiredArgsConstructor;
1313
import org.springframework.data.domain.Page;
1414
import org.springframework.data.domain.PageRequest;
15+
import org.springframework.data.domain.Sort;
1516
import org.springframework.http.HttpStatus;
1617
import org.springframework.http.ResponseEntity;
1718
import org.springframework.security.access.annotation.Secured;
@@ -49,7 +50,7 @@ public ResponseEntity<Page<SeminarAttendanceManageResponse>> getAttendances(
4950
@RequestParam(defaultValue = "10") @PositiveOrZero int size
5051
) {
5152
Page<SeminarAttendanceManageResponse> responses = seminarAttendanceService.getAttendances(
52-
PageRequest.of(page, size));
53+
PageRequest.of(page, size, Sort.by(Sort.DEFAULT_DIRECTION, "generation.generation").and(Sort.by(Sort.DEFAULT_DIRECTION,"profile.realName"))));
5354
return ResponseEntity.ok(responses);
5455
}
5556

src/test/java/com/keeper/homepage/domain/seminar/api/SeminarAttendanceControllerTest.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
2525

2626
import com.keeper.homepage.domain.member.entity.Member;
27+
import com.keeper.homepage.domain.member.entity.embedded.RealName;
2728
import com.keeper.homepage.domain.seminar.dto.request.SeminarAttendanceCodeRequest;
2829
import com.keeper.homepage.domain.seminar.dto.request.SeminarAttendanceStatusRequest;
2930
import com.keeper.homepage.domain.seminar.dto.request.SeminarStartRequest;
@@ -56,8 +57,8 @@ public class SeminarAttendanceControllerTest extends SeminarApiTestHelper {
5657

5758
@BeforeEach
5859
void setUp() {
59-
adminId = memberTestHelper.builder().build().getId();
60-
userId = memberTestHelper.builder().build().getId();
60+
adminId = memberTestHelper.builder().realName(RealName.from("김영환")).build().getId();
61+
userId = memberTestHelper.builder().realName(RealName.from("김기철")).build().getId();
6162
adminToken = jwtTokenProvider.createAccessToken(ACCESS_TOKEN, adminId, ROLE_회원, ROLE_회장);
6263
userToken = jwtTokenProvider.createAccessToken(ACCESS_TOKEN, userId, ROLE_회원);
6364

@@ -268,17 +269,17 @@ class GetSeminarAttendanceTest {
268269
mockMvc.perform(get("/seminars/attendances")
269270
.cookie(new Cookie(ACCESS_TOKEN.getTokenName(), adminToken)))
270271
.andExpect(status().isOk())
271-
.andExpect(jsonPath("$.content[0].memberId").value(adminId))
272-
.andExpect(jsonPath("$.content[0].memberName").value(admin.getRealName()))
273-
.andExpect(jsonPath("$.content[0].generation").value(admin.getGeneration()))
274-
.andExpect(jsonPath("$.content[0].attendances[0].attendanceStatus").value(ATTENDANCE.toString()))
272+
.andExpect(jsonPath("$.content[0].memberId").value(userId))
273+
.andExpect(jsonPath("$.content[0].memberName").value(user.getRealName()))
274+
.andExpect(jsonPath("$.content[0].generation").value(user.getGeneration()))
275+
.andExpect(jsonPath("$.content[0].attendances[0].attendanceId").value(attendanceId))
276+
.andExpect(jsonPath("$.content[0].attendances[0].attendanceStatus").value(LATENESS.toString()))
275277
.andExpect(jsonPath("$.content[0].attendances[0].excuse").isEmpty())
276278
.andExpect(jsonPath("$.content[0].attendances[0].attendDate").value(LocalDate.now().toString()))
277-
.andExpect(jsonPath("$.content[1].memberId").value(userId))
278-
.andExpect(jsonPath("$.content[1].memberName").value(user.getRealName()))
279-
.andExpect(jsonPath("$.content[1].generation").value(user.getGeneration()))
280-
.andExpect(jsonPath("$.content[1].attendances[0].attendanceId").value(attendanceId))
281-
.andExpect(jsonPath("$.content[1].attendances[0].attendanceStatus").value(LATENESS.toString()))
279+
.andExpect(jsonPath("$.content[1].memberId").value(adminId))
280+
.andExpect(jsonPath("$.content[1].memberName").value(admin.getRealName()))
281+
.andExpect(jsonPath("$.content[1].generation").value(admin.getGeneration()))
282+
.andExpect(jsonPath("$.content[1].attendances[0].attendanceStatus").value(ATTENDANCE.toString()))
282283
.andExpect(jsonPath("$.content[1].attendances[0].excuse").isEmpty())
283284
.andExpect(jsonPath("$.content[1].attendances[0].attendDate").value(LocalDate.now().toString()))
284285
.andDo(document("get-seminar-attendances",

0 commit comments

Comments
 (0)