Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MESHRR_MODE environment variable #22

Open
jrokeach opened this issue Oct 20, 2023 · 0 comments
Open

Remove MESHRR_MODE environment variable #22

jrokeach opened this issue Oct 20, 2023 · 0 comments

Comments

@jrokeach
Copy link
Collaborator

meshrr/meshrr/run.sh

Lines 46 to 53 in 9620996

if [[ "$MESHRR_MODE" == 'evpnrs' ]] || [[ "$MESHRR_MODE" == 'routeserver' ]] ; then
template='juniper-evpnrs.conf.j2'
elif [[ "$MESHRR_MODE" == 'ipv4rr' ]] || [[ "$MESHRR_MODE" == 'routereflector' ]] || [[ -z $MESHRR_MODE ]]; then
template='juniper-ipv4rr.conf.j2'
else
echo "Invalid MESHRR_MODE set. Must be empty or one of [ 'evpnrs' 'ipv4rr' ]."
exit 1
fi

Adds complexity with little benefit. Move to only one default template and override the template for the evpnrs use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant