Improve precompilation #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| deps = PkgId[PkgId(UUID(v), k) for (k, v) in get(prj, "deps", Dict{String,Any}())] | ||
| weakdeps = | ||
| PkgId[PkgId(UUID(v), k) for (k, v) in get(prj, "weakdeps", Dict{String,Any}())] | ||
| deps::Vector{PkgId} = PkgId[PkgId(UUID(v), k) for (k::String, v::String) in get(prj, "deps", Dict())] |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| deps::Vector{PkgId} = PkgId[PkgId(UUID(v), k) for (k::String, v::String) in get(prj, "deps", Dict())] | |
| deps::Vector{PkgId} = | |
| PkgId[PkgId(UUID(v), k) for (k::String, v::String) in get(prj, "deps", Dict())] |
| name = "Aqua" | ||
| uuid = "4c88cf16-eb10-579e-8560-4a9242c79595" | ||
| authors = ["Takafumi Arakaki <[email protected]> and contributors"] | ||
| version = "1.0.0-DEV" |
Contributor
There was a problem hiding this comment.
[JuliaProjectFormatter] reported by reviewdog 🐶
Suggested change
| version = "1.0.0-DEV" |
| authors = ["Takafumi Arakaki <[email protected]> and contributors"] | ||
| version = "1.0.0-DEV" | ||
| authors = ["Takafumi Arakaki <[email protected]> and contributors"] | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaProjectFormatter] reported by reviewdog 🐶
Suggested change
| version = "1.0.0-DEV" | |
JamesWrigley
force-pushed
the
precompile
branch
from
124a83f to
3883d38
Compare
Member
Author
|
I fixed some of the formatting issues, but I felt the other suggestions make the code less readable 🤷 |
Comment on lines
+31
to
+42
| write(project_file, """ | ||
| name = "AquaFakePackage" | ||
| uuid = "5a23b2e7-8c45-4b1c-9d3f-7a6b4c8d9e0f" | ||
| version = "0.1.0" | ||
| [deps] | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
| [compat] | ||
| Test = "1" | ||
| julia = "1" | ||
| """) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| write(project_file, """ | |
| name = "AquaFakePackage" | |
| uuid = "5a23b2e7-8c45-4b1c-9d3f-7a6b4c8d9e0f" | |
| version = "0.1.0" | |
| [deps] | |
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | |
| [compat] | |
| Test = "1" | |
| julia = "1" | |
| """) | |
| write( | |
| project_file, | |
| """ | |
| name = "AquaFakePackage" | |
| uuid = "5a23b2e7-8c45-4b1c-9d3f-7a6b4c8d9e0f" | |
| version = "0.1.0" | |
| [deps] | |
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | |
| [compat] | |
| Test = "1" | |
| julia = "1" | |
| """, | |
| ) |
In particular to `find_stale_deps()`, which took about 600ms to compile.
JamesWrigley
force-pushed
the
precompile
branch
from
3883d38 to
e08666e
Compare
| project_extras = false, | ||
| stale_deps = false, | ||
| deps_compat = false, | ||
| persistent_tasks = false) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| persistent_tasks = false) | |
| persistent_tasks = false, | |
| ) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 86.77% 87.07% +0.30%
==========================================
Files 11 12 +1
Lines 514 534 +20
==========================================
+ Hits 446 465 +19
- Misses 68 69 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
reviewed
Dec 27, 2025
Comment on lines
+3
to
+7
| # Create a minimal fake package to test | ||
| module _FakePackage | ||
| export fake_function | ||
| fake_function() = 1 | ||
| end |
Contributor
There was a problem hiding this comment.
Why not putting this inside the @setup_workload instead of saving a useless module in the compile cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to bring down the TTFX/runtime. On ZMQ.jl this brings the time for
Aqua.test_all(ZMQ)down from ~8.7s to ~6.1s, so about 30%. The downside is that the precompilation time increased from ~1.4s to ~11s, which is quite a hit. My feeling is that it's still worth it though since Aqua has relatively few dependencies and is unlikely to get invalidated frequently. I'd recommend reviewing each commit separately.