Implement tuple-pattern API: (combined, info) = frameconnect(...) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes: - Requires SMLMData ≥0.6 (adds σ_xy field to Emitter2DFit) - clusterdata column layout changed: added σ_xy as column 5 Covariance propagation: - create_costmatrix: Mahalanobis distance for separation cost, ellipse area π√det(Σ) for localization uncertainty - estimatedensities: Precision-weighted cluster centers with full 2x2 covariance matrix - combinelocalizations: Full 2x2 matrix math for combining localizations, outputs proper σ_xy_combined All 96 tests pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Breaking change: frameconnect() now returns (combined, info) tuple instead of
NamedTuple with :combined, :connected, :params fields.
New ConnectInfo{T} struct provides:
- connected::BasicSMLD{T} - input with track_id assigned
- Statistics: n_input, n_tracks, n_combined, n_preclusters
- Photophysics: k_on, k_off, k_bleach, p_miss, initialdensity
- Metadata: elapsed_ns (timing), algorithm (:lap)
Also includes:
- SMLMData 0.6 compatibility (σ_xy covariance field)
- Full covariance propagation in combinelocalizations()
- Updated documentation and tests
- Version bump to 0.3.0
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolved conflict in test/test_helpers.jl - using σ_pos naming convention from smlmdata-0.6-compat branch for clarity (σ_pos for position uncertainty, σ_xy_cov for covariance). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
Reverting tuple-pattern rollout - starting fresh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
frameconnect()now returns(combined, info)tuple instead of NamedTupleConnectInfo{T}struct with connected SMLD, statistics, photophysics, and timingChanges
New API
Files Changed
src/connectinfo.jl(new) - ConnectInfo structsrc/frameconnect.jl- new return pattern with timingsrc/combinelocalizations.jl- full 2x2 covariance propagationTest plan
🤖 Generated with Claude Code