-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please consider implementing xoshiro256** (and/or xoshiro256+) #52
Comments
I guess it would be best to implement here first; I believed we already had the best option here, thanks to you, but anyway if we had chosen, or when, could we just have copied yours to Julia's Random stdlib? I believe legally we could (even same license). I'm not sure there's some protocol to follow. I could make a PR copying code from your package. I however do not want to take credit from you or anyone. |
I finally have time to read the interesting article and this issue. Thank you for the suggestion! I have implemented It is totally OK to copy this code into Random stdlib, and it's also what I wanted. |
It seems this issue can be closed, since you implemented, thanks!
We've missed the 1.2 feature freeze, but I may do this, or anyone can, and closing this issue will signal the possibility of doing that at the linked Julialang issue. |
Thanks again, FYI I just heard of Threefry supposedly fastest, and see also in comment above mine what NumPy adopted: JuliaLang/julia#27614 (comment) EDIT: SFC64 is faster than what NumPy choose, not sure how Threefry or other compare. Looking for implementations I found: [and: https://github.com/maxmind/gatling-gen/blob/master/ext/PracRand/include/PractRand/RNGs/sfc64.h that doesn't seem helpful] |
https://nullprogram.com/blog/2017/09/21/
"xoroshiro128+ fails PractRand very badly. [..] Since this article was published, its authors have supplanted it with xoshiro256**. It has essentially the same performance, but better statistical properties. xoshiro256** is now my preferred PRNG"
See also my JuliaLang/julia#27614 (comment) for others to possibly implement (mostly Google's Randen based on AES, the one I list here would however be my first choice) and updated top comment there.
The text was updated successfully, but these errors were encountered: