Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible concurrency issues with resolve on a cluster #19

Open
amilsted opened this issue Oct 30, 2023 · 7 comments
Open

Possible concurrency issues with resolve on a cluster #19

amilsted opened this issue Oct 30, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@amilsted
Copy link
Contributor

I think I am seeing multiple processes trying to simultaneously resolve julia versions and dependencies, mirroring JuliaPy/CondaPkg.jl#40. Maybe locking is needed here too?

@cjdoris cjdoris added the bug Something isn't working label Oct 31, 2023
@cjdoris
Copy link
Collaborator

cjdoris commented Oct 31, 2023

Yeah makes sense.

@amilsted
Copy link
Contributor Author

Oh, by the way, I wonder if "pidfile" locking makes sense on a cluster? I think it probably doesn't, since there is no global list of processes.

@cjdoris
Copy link
Collaborator

cjdoris commented Nov 2, 2023

I just took a look at the source:

https://github.com/vtjnash/Pidfile.jl/blob/67c3f23b25d4e43f1f5785ce77c2cac6952fefcf/src/Pidfile.jl#L128

Pidfile.jl uses both the PID and hostname, which presumably means it works with shared filesystems too.

@amilsted
Copy link
Contributor Author

amilsted commented Nov 2, 2023

Ah, that's smart! Much better than https://github.com/mosquito/python-pidfile/blob/master/pidfile/pidfile.py

https://github.com/keiranmraine/pidlock sees to use hostname too.

@cjdoris
Copy link
Collaborator

cjdoris commented Nov 2, 2023

Oh yeah of course this is a python package so need a python implementation of pidfiles.

@cjdoris
Copy link
Collaborator

cjdoris commented Nov 2, 2023

pidlock looks good thanks

@amilsted
Copy link
Contributor Author

amilsted commented Nov 2, 2023

Btw, is it really necessary to write out the meta file every time? Perhaps we could check for changes first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants