svd!: allow lower bidiagonal #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close JuliaLinearAlgebra/TSVD.jl#33 TSVD requires the SVD of a lower bidiagonal matrix. If the element type is not one supported by LAPACK and if GenericLinearAlgebra is imported, the call dispatches to it. However, GenericLinearAlgebra only implements the SVD of an *upper* bidiagonal. This PR introduces a helper function to pass the transposed of the bidiagonal if the latter is a lower bidiagonal. As a result, the truncated SVD of a matrix of, say, BigFloat, is now possible.
|
I'm happy to remove the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 10 10
Lines 1441 1443 +2
=======================================
+ Hits 1388 1390 +2
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close JuliaLinearAlgebra/TSVD.jl#33
TSVD requires the SVD of a lower bidiagonal matrix. If the element type is not one supported by LAPACK and if GenericLinearAlgebra is imported, the call dispatches to it. However, GenericLinearAlgebra only implements the SVD of an upper bidiagonal.
This PR introduces a helper function to pass the transposed of the bidiagonal if the latter is a lower bidiagonal.
As a result, the truncated SVD of a matrix of, say, BigFloat, is now possible.