Skip to content

Code quality improvements — Aqua tests, Database import fix, remove Embedding wrapper - #41

Merged
ParamThakkar123 merged 9 commits into
mainfrom
code_quality
Jun 13, 2026
Merged

ParamThakkar123 merged 9 commits into
mainfrom
code_quality

Conversation

@ParamThakkar123

Copy link
Copy Markdown
Collaborator

Summary

19. Add Aqua.jl tests

Created test/aqua.jl with Aqua.test_all covering ambiguities, stale deps, deps compat, and piracy. Added Aqua to [extras] in Project.toml.

20. Manifest.toml

Verified: already untracked — .gitignore correctly excludes Manifest*.toml and no Manifest.toml exists in the git index.

21. Fix Database.jl fragile import

Replaced using ..Pgvector: convert + import Base: convert (which caused method ambiguity with Base) with a local _vector_to_pgarray helper. Removed the now-unused pgvector.jl submodule entirely.

22. Remove thin Embedding.jl wrapper

embedding.jl was a 3-line module that just delegated to RAGTools.build_index. Inlined build_index_rag into Utils and deleted the file.

@codecov

codecov Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 27.27%. Comparing base (ab3aa76) to head (8c40129).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/database.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   22.98%   27.27%   +4.28%     
==========================================
  Files           6        4       -2     
  Lines          87       88       +1     
==========================================
+ Hits           20       24       +4     
+ Misses         67       64       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ParamThakkar123
ParamThakkar123 merged commit 54fdc11 into main Jun 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant