Testing

Author: christiangnrd

lib/mtl/command_enc/compute4.jl

@@ -13,11 +13,12 @@ function MTL4ComputeCommandEncoder(cmdbuf::MTL4CommandBuffer)
 end
 
 
-function MTL4ComputeCommandEncoder(f::Base.Callable, cmdbuf::MTL4CommandBuffer)
+function MTL4ComputeCommandEncoder(f::Base.Callable, cmdbuf::MTL4CommandBuffer, sync=false)
     encoder = MTL4ComputeCommandEncoder(cmdbuf)
     try
         f(encoder)
     finally
+        sync && barrierAfterStages!(encoder)
         close(encoder)
     end
 end

src/compiler/execution.jl

@@ -308,6 +308,7 @@ end
         MTL.append_current_function!(cce, groups, threads)
         bufs
     finally
+        use_mtl4 && barrierAfterStages!(cce)
         close(cce)
         use_mtl4 && endCommandBuffer!(cmdbuf)
     end

src/memory.jl

@@ -97,17 +97,24 @@ end
 
 @autoreleasepool function unsafe_fill!(dev::MTLDevice, dst::MtlPtr{T},
                                        value::Union{UInt8,Int8}, N::Integer;
-                                       queue::MTLCommandQueue=global_queue(dev),
+                                       queue=use_metal4() ? global_queue4(dev) : global_queue(dev),
                                        async::Bool=false) where T
     if N > 0
-        cmdbuf = MTLCommandBuffer(queue)
-        MTLBlitCommandEncoder(cmdbuf) do enc
-            MTL.append_fillbuffer!(enc, dst.buffer, value, N * sizeof(T), dst.offset)
+        if queue isa MTL4CommandQueue 
+            @info "4"
+            cmdbuf = MTL4CommandBuffer(dev; queue) do cmdbuf
+                MTL4ComputeCommandEncoder(cmdbuf, !async) do enc
+                    MTL.append_fillbuffer!(enc, dst.buffer, value, N * sizeof(T), dst.offset)
+                end
+            end
+        else
+            cmdbuf = MTLCommandBuffer(queue)
+            MTLBlitCommandEncoder(cmdbuf) do enc
+                MTL.append_fillbuffer!(enc, dst.buffer, value, N * sizeof(T), dst.offset)
+            end
+            commit!(cmdbuf)
+            async || wait_completed(cmdbuf)
         end
-        commit!(cmdbuf)
-        async || wait_completed(cmdbuf)
     end
     return dst
 end
-
-# TODO: Implement generic fill since mtBlitCommandEncoderFillBuffer is limiting