Merge pull request #788 from JuliaGPU/tb/speedup_rand

Speed-up rand: Tausworthe RNG with shared random state.

Author: maleadt

.buildkite/pipeline.yml

@@ -57,7 +57,7 @@ steps:
   - label: "CUDA 11.2"
     plugins:
       - JuliaCI/julia#v1:
-          version: 1.6
+          version: 1.6-nightly
       - JuliaCI/julia-test#v1:
           test_args: "--thorough"
       - JuliaCI/julia-coverage#v1:
@@ -79,7 +79,7 @@ steps:
   - label: "CUDA 11.1"
     plugins:
       - JuliaCI/julia#v1:
-          version: 1.6
+          version: 1.6-nightly
       - JuliaCI/julia-test#v1:
           test_args: "--thorough"
       - JuliaCI/julia-coverage#v1:
@@ -101,7 +101,7 @@ steps:
   - label: "CUDA 11.0"
     plugins:
       - JuliaCI/julia#v1:
-          version: 1.6
+          version: 1.6-nightly
       - JuliaCI/julia-test#v1:
           test_args: "--thorough"
       - JuliaCI/julia-coverage#v1:
@@ -123,7 +123,7 @@ steps:
   - label: "CUDA 10.2"
     plugins:
       - JuliaCI/julia#v1:
-          version: 1.6
+          version: 1.6-nightly
       - JuliaCI/julia-test#v1:
           test_args: "--thorough"
       - JuliaCI/julia-coverage#v1:
@@ -145,7 +145,7 @@ steps:
   - label: "CUDA 10.1"
     plugins:
       - JuliaCI/julia#v1:
-          version: 1.6
+          version: 1.6-nightly
       - JuliaCI/julia-test#v1:
           test_args: "--thorough"
       - JuliaCI/julia-coverage#v1:

perf/kernel.jl

@@ -26,3 +26,10 @@ function checked_indexing_kernel(dest, src)
     return
 end
 group["indexing_checked"] = @async_benchmarkable @cuda threads=size(src,1) blocks=size(src,2) $checked_indexing_kernel($dest, $src)
+
+function rand_kernel(dest::AbstractArray{T}) where {T}
+    i = (blockIdx().x-1) * blockDim().x + threadIdx().x
+    dest[i] = rand(T)
+    return
+end
+group["rand"] = @async_benchmarkable @cuda threads=size(src,1) blocks=size(src,2) $rand_kernel($dest)

src/CUDA.jl

@@ -57,6 +57,7 @@ include("device/intrinsics.jl")
 include("device/llvm.jl")
 include("device/runtime.jl")
 include("device/texture.jl")
+include("device/random.jl")
 
 # array essentials
 include("pool.jl")

src/compiler/execution.jl

@@ -200,15 +200,13 @@ end
 
 ## host-side kernels
 
-mutable struct HostKernel{F,TT} <: AbstractKernel{F,TT}
+struct HostKernel{F,TT} <: AbstractKernel{F,TT}
     ctx::CuContext
     mod::CuModule
     fun::CuFunction
 
-    random_state::Union{Nothing,Missing,CuVector{UInt32}}
-
-    function HostKernel{F,TT}(ctx::CuContext, mod::CuModule, fun::CuFunction, random_state) where {F,TT}
-        kernel = new{F,TT}(ctx, mod, fun, random_state)
+    function HostKernel{F,TT}(ctx::CuContext, mod::CuModule, fun::CuFunction) where {F,TT}
+        kernel = new{F,TT}(ctx, mod, fun)
     end
 end
 
@@ -358,19 +356,17 @@ function cufunction_link(@nospecialize(job::CompilerJob), compiled)
         filter!(!isequal("exception_flag"), compiled.external_gvars)
     end
 
-    random_state = nothing
-    if "global_random_state" in compiled.external_gvars
+    # initialize random seeds, if used
+    if "global_random_seed" in compiled.external_gvars
         random_state = missing
-        filter!(!isequal("global_random_state"), compiled.external_gvars)
+        initialize_random_seeds!(mod)
+        filter!(!isequal("global_random_seed"), compiled.external_gvars)
     end
 
-    return HostKernel{job.source.f,job.source.tt}(ctx, mod, fun, random_state)
+    return HostKernel{job.source.f,job.source.tt}(ctx, mod, fun)
 end
 
 function (kernel::HostKernel)(args...; threads::CuDim=1, blocks::CuDim=1, kwargs...)
-    if kernel.random_state !== nothing
-        init_random_state!(kernel, prod(threads) * prod(blocks))
-    end
     call(kernel, map(cudaconvert, args)...; threads, blocks, kwargs...)
 end
 

src/device/intrinsics.jl

@@ -41,7 +41,6 @@ include("intrinsics/memory_dynamic.jl")
 include("intrinsics/atomics.jl")
 include("intrinsics/misc.jl")
 include("intrinsics/wmma.jl")
-include("intrinsics/random.jl")
 
 # functionality from libdevice
 #