Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AMGX_jll 2.3 and bump julia compat to 1.6 #28

Closed
wants to merge 5 commits into from
Closed

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Feb 9, 2023

No description provided.

@vchuravy
Copy link
Member Author

vchuravy commented Feb 9, 2023

In conversation with @maleadt we should yank the previous release since it falsly promises compat with CUDA@4.

@moyner
Copy link
Contributor

moyner commented Oct 20, 2024

Hi! Any interest in updating this? The JLL is already built. I guess the latest AMGX 2.4.0 https://github.com/NVIDIA/AMGX/releases/tag/v2.4.0 would also be nice to have - then CUDA 12 is supported and it would be possible to use AMGX in later Julia versions from what I gather.

@maleadt
Copy link
Member

maleadt commented Oct 21, 2024

I don't think any of us is using AGMX.jl right now, so your best bet is to look into this yourself. Feel free to reach out if you have any issues though. For support with AMGX v2.4, you'd need to update the build recipe here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AMGX/build_tarballs.jl

@moyner
Copy link
Contributor

moyner commented Oct 21, 2024

I don't think any of us is using AGMX.jl right now, so your best bet is to look into this yourself. Feel free to reach out if you have any issues though. For support with AMGX v2.4, you'd need to update the build recipe here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AMGX/build_tarballs.jl

Thanks! I'm having a go at this. I tried updating the script to the latest release, but I ended up stuck at messages of the type cuda_architectures is empty for target xxx. where xxx would be for example cmtc_d1232. If I try the original build script I see that the same happens for the unmodified script if I change the CUDA versions to be what is currently supported in BinaryBuilder's cuda.jl.

I can build the AMGX binaries without issue with CMake outside of Julia, but I'm having some difficulty understanding how to get it to build from within the Julia script. Am I supposed to target the latest CUDA? Can I do that since BB needs Julia 1.7 and not later? I think the changes in AMGX are not too large to handle, but I'd ideally have a baseline build of the old binaries to start from.

@maleadt
Copy link
Member

maleadt commented Oct 21, 2024

I'll update the build recipe.

@maleadt
Copy link
Member

maleadt commented Oct 22, 2024

JuliaPackaging/Yggdrasil#9657

@moyner
Copy link
Contributor

moyner commented Oct 22, 2024

Thanks a lot - I will try to make a PR that updates AMGX.jl to use the new JLL and latest versions based off this PR unless anyone else is already doing it.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (f812a39) to head (197f7b3).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f812a39) and HEAD (197f7b3). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f812a39) HEAD (197f7b3)
6 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   94.34%   88.92%   -5.43%     
==========================================
  Files           9        9              
  Lines         336      334       -2     
==========================================
- Hits          317      297      -20     
- Misses         19       37      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison deleted the vc/2.3 branch November 22, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants