-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AMGX_jll 2.3 and bump julia compat to 1.6 #28
Conversation
In conversation with @maleadt we should yank the previous release since it falsly promises compat with CUDA@4. |
Hi! Any interest in updating this? The JLL is already built. I guess the latest AMGX 2.4.0 https://github.com/NVIDIA/AMGX/releases/tag/v2.4.0 would also be nice to have - then CUDA 12 is supported and it would be possible to use AMGX in later Julia versions from what I gather. |
I don't think any of us is using AGMX.jl right now, so your best bet is to look into this yourself. Feel free to reach out if you have any issues though. For support with AMGX v2.4, you'd need to update the build recipe here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AMGX/build_tarballs.jl |
Thanks! I'm having a go at this. I tried updating the script to the latest release, but I ended up stuck at messages of the type I can build the AMGX binaries without issue with CMake outside of Julia, but I'm having some difficulty understanding how to get it to build from within the Julia script. Am I supposed to target the latest CUDA? Can I do that since BB needs Julia 1.7 and not later? I think the changes in AMGX are not too large to handle, but I'd ideally have a baseline build of the old binaries to start from. |
I'll update the build recipe. |
Thanks a lot - I will try to make a PR that updates AMGX.jl to use the new JLL and latest versions based off this PR unless anyone else is already doing it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 94.34% 88.92% -5.43%
==========================================
Files 9 9
Lines 336 334 -2
==========================================
- Hits 317 297 -20
- Misses 19 37 +18 ☔ View full report in Codecov by Sentry. |
No description provided.