-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javis Animation Dev Mode #166
Comments
I think it's an interesting idea but had a different implementation in mind. The current problem with your idea is: if I change the first frame in the second run this world not work so I would need to call it without dev mode but normally I only add frames so I would run it again in dev mode. I can imagine that this will be very frustrating. What I have in mind: specify a frames keyword argument or To keep yours in mind one could specify a symbol What do you think? |
@Wikunia @TheCedarPrince Can I work on this issue? |
Sure would be great to post your ideas of how to tackle this issue first as we haven't come to a conclusion yet 😄 |
Sure, will do that. Thanks! |
@Wikunia I just needed a small clarification. The |
Yes will update that. In the first versions we called it |
@Wikunia @TheCedarPrince I went through the code logic for |
@Wikunia @TheCedarPrince I tried to find why it would not affect (speed up) the rendering time even after not recomputing unchanged frames. I benchmarked the code and as usual the Hence, this method to speed up will not work. I will play around a bit more and see any potential work-around for it otherwise you might close it. |
One idea of this was that the frames stay in memory and are not loaded from a file. This might be only possible in the mp4 case at the moment though |
Is your feature request related to a problem? Please explain.
When developing Javis animations that take hundreds of frames, I have found that when I run the
render
command it has to recompile and make all the hundreds of frames. I am impatient and do not want to wait when developing!Describe the solution you'd like
Therefore, I think we could implement a
kwarg
likedebug::Bool
ordev_mode::Bool
in therender
function that will do the following:dev_mode == True
activate development moderender
function and save them as image files in a temp directoryUpon running of the
render
function withdev_mode == True
again with more frames added:Therefore, saving time on development compilation by having frames that were previously rendered be saved.
Additional context
Based on discussion with @Wikunia !
The text was updated successfully, but these errors were encountered: