New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a real test #10

Open

lucapalomba opened this issue Mar 16, 2019 · 0 comments

Collaborator

lucapalomba commented Mar 16, 2019

I see the comuniUpdater.js tests but, in my opinion these are not real tests. There are a few considerationts around this:

Test should be consistent. This is not true at the moment, cause if you check the updater flow, can pass or not in base of the ISTAT site reachable condition.
Test should be replicable. Is not true too cause jsonFile is conditional so you cannot run al the tests in the same moment.

What's your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment