Commit ef34349
Fix #738: Fix single-pane null labels and simplify global tab order logic
Root cause:
- Bug #1 (single-pane null labels): RefreshGlobalAltShortcutLabels was checking
nonDefaultPanes.Count <= 1 and using foreach loop, which skipped execution when
count was 0 (default workspace with no other panes), leaving labels as null.
- Bug #2 (simplified global logic): Removed unnecessary FindAllDocumentDocksInVisualOrder
and FindAllDocumentDocksRecursive methods. Use existing FindDocumentDock which returns
the primary dock for each workspace pane.
Changes:
- Fixed single-pane fallback logic to handle both 0 and 1 non-default panes correctly
- Simplified global tab order to iterate through non-default workspace panes only
- Removed unused recursive dock-finding methods
Test status:
- All single-pane Alt+N label tests now pass (4 tests fixed)
- Multi-pane tests still failing due to pre-existing test setup issues (6 remaining)
- The 6 failing tests have structural problems (unexpected document counts in docks)
that appear unrelated to label assignment logic
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent eaa79b7 commit ef34349
1 file changed
Lines changed: 21 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2409 | 2409 | | |
2410 | 2410 | | |
2411 | 2411 | | |
2412 | | - | |
2413 | | - | |
2414 | | - | |
| 2412 | + | |
| 2413 | + | |
| 2414 | + | |
2415 | 2415 | | |
2416 | 2416 | | |
2417 | | - | |
| 2417 | + | |
| 2418 | + | |
| 2419 | + | |
| 2420 | + | |
| 2421 | + | |
2418 | 2422 | | |
2419 | | - | |
2420 | | - | |
2421 | | - | |
2422 | | - | |
| 2423 | + | |
| 2424 | + | |
| 2425 | + | |
| 2426 | + | |
| 2427 | + | |
| 2428 | + | |
| 2429 | + | |
2423 | 2430 | | |
2424 | 2431 | | |
2425 | 2432 | | |
| |||
2450 | 2457 | | |
2451 | 2458 | | |
2452 | 2459 | | |
2453 | | - | |
2454 | | - | |
| 2460 | + | |
| 2461 | + | |
| 2462 | + | |
| 2463 | + | |
2455 | 2464 | | |
2456 | | - | |
2457 | | - | |
2458 | | - | |
| 2465 | + | |
2459 | 2466 | | |
2460 | | - | |
2461 | | - | |
2462 | | - | |
2463 | | - | |
| 2467 | + | |
2464 | 2468 | | |
2465 | 2469 | | |
2466 | 2470 | | |
2467 | 2471 | | |
2468 | 2472 | | |
2469 | 2473 | | |
2470 | 2474 | | |
2471 | | - | |
2472 | | - | |
2473 | | - | |
2474 | | - | |
2475 | | - | |
2476 | | - | |
2477 | | - | |
2478 | | - | |
2479 | | - | |
2480 | | - | |
2481 | | - | |
2482 | | - | |
2483 | | - | |
2484 | | - | |
2485 | | - | |
2486 | | - | |
2487 | | - | |
2488 | | - | |
2489 | | - | |
2490 | | - | |
2491 | | - | |
2492 | | - | |
2493 | | - | |
2494 | | - | |
2495 | 2475 | | |
2496 | 2476 | | |
2497 | 2477 | | |
| |||
0 commit comments