Skip to content

Commit b6f1204

Browse files
committed
update for gitea 1.21
(cherry picked from commit f6ed408)
1 parent b644e6d commit b6f1204

File tree

3 files changed

+13
-15
lines changed

3 files changed

+13
-15
lines changed

Diff for: commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/gitea/GiteaBuildStatus.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ public enum GiteaBuildStatus {
2828
PENDING("pending"),
2929
SUCCESS("success"),
3030
ERROR("error"),
31-
FAILURE("failure"),
32-
WARNING("warning");
31+
FAILURE("failure");
3332

3433
private static final Map<String, GiteaBuildStatus> INDEX = Arrays.stream(values()).collect(Collectors.toMap(GiteaBuildStatus::getName, Function.identity()));
3534

Diff for: commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/gitea/GiteaPublisher.java

+7-8
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public boolean buildQueued(@NotNull BuildPromotion buildPromotion, @NotNull Buil
7777

7878
@Override
7979
public boolean buildRemovedFromQueue(@NotNull BuildPromotion buildPromotion, @NotNull BuildRevision revision, @NotNull AdditionalTaskInfo additionalTaskInfo) throws PublisherException {
80-
publish(buildPromotion, revision, GiteaBuildStatus.WARNING , additionalTaskInfo);
80+
publish(buildPromotion, revision, GiteaBuildStatus.FAILURE, additionalTaskInfo);
8181
return true;
8282
}
8383

@@ -111,7 +111,7 @@ public boolean buildMarkedAsSuccessful(@NotNull SBuild build, @NotNull BuildRevi
111111

112112
@Override
113113
public boolean buildInterrupted(@NotNull SBuild build, @NotNull BuildRevision revision) throws PublisherException {
114-
publish(build, revision, GiteaBuildStatus.WARNING, build.getStatusDescriptor().getText());
114+
publish(build, revision, GiteaBuildStatus.FAILURE, build.getStatusDescriptor().getText());
115115
return true;
116116
}
117117

@@ -208,11 +208,6 @@ private Event getTriggeredEvent(GiteaCommitStatus commitStatus) {
208208
}
209209

210210
switch (status) {
211-
case WARNING:
212-
return commitStatus.description != null
213-
&& (commitStatus.description.contains(DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE)
214-
|| commitStatus.description.contains(DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE_AS_CANCELED))
215-
? Event.REMOVED_FROM_QUEUE : null;
216211
case PENDING:
217212
if (commitStatus.description == null || commitStatus.description.contains(DefaultStatusMessages.BUILD_QUEUED)) {
218213
return Event.QUEUED;
@@ -224,9 +219,13 @@ private Event getTriggeredEvent(GiteaCommitStatus commitStatus) {
224219
return null;
225220
}
226221
case SUCCESS:
227-
case FAILURE:
228222
case ERROR:
229223
return null;
224+
case FAILURE:
225+
return commitStatus.description != null
226+
&& (commitStatus.description.contains(DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE)
227+
|| commitStatus.description.contains(DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE_AS_CANCELED))
228+
? Event.REMOVED_FROM_QUEUE : null;
230229
default:
231230
LOG.warn("No event is assosiated with Gitea build status \"" + status + "\". Related event can not be defined");
232231
}

Diff for: commit-status-publisher-server/src/test/java/jetbrains/buildServer/commitPublisher/gitea/GiteaPublisherTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,15 @@ public class GiteaPublisherTest extends HttpPublisherTest {
5050

5151
public GiteaPublisherTest() {
5252
myExpectedRegExps.put(EventToTest.QUEUED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*pending.*%s.*", REVISION, DefaultStatusMessages.BUILD_QUEUED));
53-
myExpectedRegExps.put(EventToTest.REMOVED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*warning.*%s\".*", REVISION, DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE));
53+
myExpectedRegExps.put(EventToTest.REMOVED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*failure.*%s\".*", REVISION, DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE));
5454
myExpectedRegExps.put(EventToTest.STARTED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*pending.*%s.*", REVISION, DefaultStatusMessages.BUILD_STARTED));
5555
myExpectedRegExps.put(EventToTest.FINISHED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*success.*Success.*", REVISION));
5656
myExpectedRegExps.put(EventToTest.FAILED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*failure.*Failure.*", REVISION));
5757
myExpectedRegExps.put(EventToTest.COMMENTED_SUCCESS, null); // not to be tested
5858
myExpectedRegExps.put(EventToTest.COMMENTED_FAILED, null); // not to be tested
5959
myExpectedRegExps.put(EventToTest.COMMENTED_INPROGRESS, null); // not to be tested
6060
myExpectedRegExps.put(EventToTest.COMMENTED_INPROGRESS_FAILED, null); // not to be tested
61-
myExpectedRegExps.put(EventToTest.INTERRUPTED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*warning.*%s.*", REVISION, PROBLEM_DESCR));
61+
myExpectedRegExps.put(EventToTest.INTERRUPTED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*failure.*%s.*", REVISION, PROBLEM_DESCR));
6262
myExpectedRegExps.put(EventToTest.FAILURE_DETECTED, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*failure.*%s.*", REVISION, PROBLEM_DESCR));
6363
myExpectedRegExps.put(EventToTest.MARKED_SUCCESSFUL, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*success.*%s.*", REVISION, DefaultStatusMessages.BUILD_MARKED_SUCCESSFULL));
6464
myExpectedRegExps.put(EventToTest.MARKED_RUNNING_SUCCESSFUL, String.format(".*/repos/owner/project/statuses/%s.*ENTITY:.*pending.*%s.*", REVISION, DefaultStatusMessages.BUILD_MARKED_SUCCESSFULL));
@@ -132,11 +132,11 @@ public void should_calculate_correct_revision_status() {
132132
assertNull(publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.PENDING.getName(), DefaultStatusMessages.BUILD_MARKED_SUCCESSFULL, null, null)).getTriggeredEvent());
133133
assertEquals(CommitStatusPublisher.Event.QUEUED, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.PENDING.getName(), null, null, null)).getTriggeredEvent());
134134
assertEquals(CommitStatusPublisher.Event.STARTED, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.PENDING.getName(), DefaultStatusMessages.BUILD_STARTED, null, null)).getTriggeredEvent());
135-
assertEquals(CommitStatusPublisher.Event.REMOVED_FROM_QUEUE, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.WARNING.getName(), DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE, null, null)).getTriggeredEvent());
136-
assertEquals(CommitStatusPublisher.Event.REMOVED_FROM_QUEUE, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.WARNING.getName(), DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE_AS_CANCELED, null, null)).getTriggeredEvent());
135+
assertEquals(CommitStatusPublisher.Event.REMOVED_FROM_QUEUE, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.FAILURE.getName(), DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE, null, null)).getTriggeredEvent());
136+
assertEquals(CommitStatusPublisher.Event.REMOVED_FROM_QUEUE, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.FAILURE.getName(), DefaultStatusMessages.BUILD_REMOVED_FROM_QUEUE_AS_CANCELED, null, null)).getTriggeredEvent());
137137
assertNull(publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.PENDING.getName(), "", null, null)).getTriggeredEvent());
138138
assertEquals(CommitStatusPublisher.Event.QUEUED, publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.PENDING.getName(), DefaultStatusMessages.BUILD_QUEUED, null, null)).getTriggeredEvent());
139-
assertNull(publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.WARNING.getName(), null, null, null)).getTriggeredEvent());
139+
assertNull(publisher.getRevisionStatus(promotion, new GiteaCommitStatus(null, GiteaBuildStatus.FAILURE.getName(), null, null, null)).getTriggeredEvent());
140140
}
141141

142142
public void should_allow_queued_depending_on_build_type() {

0 commit comments

Comments
 (0)