Revert "TW-84882: if collecting changes fails, still try to publish commit statuses to Space by using the unknown git SHA revision"

This reverts commit b370da8.

Author: aeisele

commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/BaseCommitStatusPublisher.java

@@ -16,8 +16,6 @@
 
 package jetbrains.buildServer.commitPublisher;
 
-import java.util.Collection;
-import java.util.Collections;
 import java.util.Map;
 import jetbrains.buildServer.serverSide.*;
 import jetbrains.buildServer.users.User;
@@ -105,12 +103,6 @@ public void setConnectionTimeout(int timeout) {
     myConnectionTimeout = timeout;
   }
 
-  @NotNull
-  @Override
-  public Collection<BuildRevision> getFallbackRevisions() {
-    return Collections.emptyList();
-  }
-
   @Nullable
   public String getVcsRootId() {
     return myParams.get(Constants.VCS_ROOT_ID_PARAM);

commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/CommitStatusPublisher.java

@@ -16,7 +16,6 @@
 
 package jetbrains.buildServer.commitPublisher;
 
-import java.util.Collection;
 import jetbrains.buildServer.serverSide.*;
 import jetbrains.buildServer.users.User;
 import org.jetbrains.annotations.NotNull;
@@ -70,17 +69,6 @@ public interface CommitStatusPublisher {
 
   void setConnectionTimeout(int timeout);
 
-  /**
-   * Returns the <em>(VCS specific)</em> fallback revisions to be used if no {@link BuildRevision}s could be determined.
-   * <p>
-   * <em>Note:</em> Publishing statuses to an unknown / fallback revisions only makes sense in very limited use cases.
-   * Currently only {@link jetbrains.buildServer.commitPublisher.space.SpacePublisher} supports this.
-   * </p>
-   *
-   * @return empty collection if this publisher doesn't support fallback revisions
-   */
-  @NotNull
-  Collection<BuildRevision> getFallbackRevisions();
 
   enum Event {
     STARTED("buildStarted", EventPriority.FIRST, true), FINISHED("buildFinished", true),

commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/CommitStatusPublisherListener.java

@@ -645,7 +645,7 @@ private boolean shouldFailBuild(@NotNull SBuildType buildType) {
   private Collection<BuildRevision> getQueuedBuildRevisionForVote(@NotNull BuildType buildType,
                                                             @NotNull CommitStatusPublisher publisher,
                                                             @NotNull BuildPromotion buildPromotion) {
-    if (buildPromotion.isFailedToCollectChanges()) return publisher.getFallbackRevisions();
+    if (buildPromotion.isFailedToCollectChanges()) return Collections.emptyList();
 
     if (!((BuildPromotionEx)buildPromotion).isChangeCollectingNeeded(false)) {
       return getBuildRevisionForVote(publisher, buildPromotion.getRevisions());
@@ -819,7 +819,7 @@ public RetryInfo publish(Event event, BuildRevision revision, CommitStatusPublis
 
         @Override
         public Collection<BuildRevision> getRevisions(BuildType buildType, CommitStatusPublisher publisher) {
-          if (buildPromotion.isFailedToCollectChanges()) return publisher.getFallbackRevisions();
+          if (buildPromotion.isFailedToCollectChanges()) return Collections.emptyList();
           return getBuildRevisionForVote(publisher, build.getRevisions());
         }
       };

commit-status-publisher-server/src/main/java/jetbrains/buildServer/commitPublisher/space/SpacePublisher.java

@@ -29,7 +29,6 @@
 import jetbrains.buildServer.serverSide.oauth.space.SpaceConnectDescriber;
 import jetbrains.buildServer.util.StringUtil;
 import jetbrains.buildServer.vcs.VcsModification;
-import jetbrains.buildServer.vcs.VcsRootInstance;
 import jetbrains.buildServer.vcshostings.http.HttpHelper;
 import org.apache.http.HttpHeaders;
 import org.apache.http.entity.ContentType;
@@ -40,7 +39,6 @@
 
 public class SpacePublisher extends HttpBasedCommitStatusPublisher<SpaceBuildStatus> {
   private static final String UNKNOWN_BUILD_CONFIGURATION = "Unknown build configuration";
-  private static final String UNKNWON_GIT_SHA = "0000000000000000000000000000000000000000";
 
   private final SpaceConnectDescriber mySpaceConnector;
   private final Gson myGson = new Gson();
@@ -368,23 +366,4 @@ public void processResponse(HttpHelper.HttpResponse response) throws HttpPublish
       throw new HttpPublisherException(statusCode, response.getStatusText(), "HTTP response error: " + (responseContent != null ? responseContent : "<empty>"));
     }
   }
-
-  /**
-   * Returns the <em>"unknown git SHA"</em> revision.
-   * This revision can serve as a fallback.
-   * Space is able to match safe-merge statuses by build ID.
-   * See: TW-84882
-   *
-   * @return singleton collection of an artificial build revision pointing to {@link #UNKNWON_GIT_SHA}
-   */
-  @NotNull
-  @Override
-  public Collection<BuildRevision> getFallbackRevisions() {
-    final List<VcsRootInstance> vcsRootInstances = myBuildType.getVcsRootInstances();
-    if (vcsRootInstances.isEmpty()) {
-      LOG.warn("unable to construct fallback build revision for Space build " + LogUtil.describe(myBuildType) + ": no VCS root instances found");
-      return super.getFallbackRevisions();
-    }
-    return Collections.singletonList(new BuildRevision(vcsRootInstances.get(0), UNKNWON_GIT_SHA, "", UNKNWON_GIT_SHA));
-  }
 }