Jetty changes?

[wacko-cornflower]

Hi,
Im in the process of updating some graphana dashboards that we have used for some tracking of the overall state of jans. However when upgrading from 1.5.0 to the 1.80 the jetty related ones went dark.

I have tried to verify that the configurations are setup correctly so in my mind it should be correctly setup. We have enabled http_logging etc. The prometheus.yaml config looks lite it is correct. I have followed the documentation here previously but cant seem to find the relevant updated one in 1.8.0.
An example metric is org_eclipse_jetty_server_handler_statisticshandler_requesttimetotal that is no longer to be found.

Is there something obvious that I have overlooked?

[wacko-cornflower]

FYI it seems that with the update of the jans version the jetty version was updated as well and in that process the aforementioned metric was deprecated. However there are new ones that would do the trick but it seems that there is a need for additional modules being loaded into the container. Specifically one called micrometer. Are there plans for adding that or something equivalent or should i bake a new image myself?

[ossdhaval]

@wacko-cornflower Welcome to the Janssen Project discussions. 🤝

@yurem @devrimyatar, what is your opinion on this?

[moabu]

Hey @wacko-cornflower ,

Yes we do want to continue to support loading metrics as we did before. Sometimes we get pressured to upgrade due to security concerns. @wacko-cornflower would you like to open a PR targeting an issue in this regard so we work together on this. Your contributions would be greatly appreciated.

Thanks,

[wacko-cornflower]

Will see if I am able that get something. Will have somewhat of a starting phase due to not having the dev environment up and running.

[ossdhaval]

Will see if I am able that get something. Will have somewhat of a starting phase due to not having the dev environment up and running.

Let us know if you face any hiccups during dev environment setup. Mostly, we should be able to help you out. Also, make sure you go through the contribution guide to setup your git correctly for commits.

[moabu]

@wacko-cornflower I think there might be a confusion here. Are you looking for https://javadoc.io/doc/org.eclipse.jetty/jetty-server/12.0.19/org.eclipse.jetty.server/org/eclipse/jetty/server/handler/StatisticsHandler.html#getRequestTimeTotal() because thats not deprecated.

[wacko-cornflower]

Hmm. That's strange. Let me backtrack and see if I can't find the links to where I read what I read about deprecation. Might have gotten something wrong. Should have posted it here directly...

Although regardless we have some difficulty getting jetty related metrics still. Primarily the different responses[2|3|4|5]xxx. Will continue digging and report back

[wacko-cornflower]

I have run into a snag. I need to determine what my company policy is regarding upstream contributions before i do too much on this. Will have to take a step back on this until then.

Is there anyone else that has reported any issues with this?

[ossdhaval]

@wacko-cornflower No, there are no other reports about this. But we will keep an eye open for a similar report.

Please do check your policy. We would love to see your continued engagement in the Janssen community.