Add trailing dot to cnames

[peterablehmann]

This makes the behavior consistent between NS, MX, SRV and CNAME records.

If you use CNAMEs a trailing dot will now be added automatically.
This behavior is in line with other record types that use dns names.

This breaks using subdomain paths in CNAMEs and if you are using full domain names
in CNAMEs you will need to remove the trailing dot in your config.

zones."example.org"."example".cname.data = "example2"-> example.example.org IN CNAME example2.
You will now have to write it as:
zones."example.org"."example".cname.data = "example2.example.org"-> example.example.org IN CNAME example2.example.org.

[Janik-Haag]

Uh seems like you found a bug :)
Would you mind adding something like:

      "myFancyRedirect".cname.data = "example.net.";

to the example.com zone in example/dns.nix, so it also gets automatically tested in ci other then that the change looks good to me.

[Janik-Haag]

uh and you have to updated the existing unit tests ^^

[peterablehmann]

Uh seems like you found a bug :) Would you mind adding something like:

      "myFancyRedirect".cname.data = "example.net.";

to the example.com zone in example/dns.nix, so it also gets automatically tested in ci other then that the change looks good to me.

I'm not sure what you want me to do. There is already a correct CNAME example present. "redirect".cname.data = "example.net"; And wouldn't a wrong one only confuse future users?