Repository navigation
Commit ee4b85b
authored
Fix NXP MCUXpresso CIFAR link failure (pytorch#24510)
Main-branch counterpart of release/1.6 fix pytorch#24509. Fixes the NXP
MCUXpresso failure seen on pytorch#24490; main has the same incomplete CMake
target.
The [failed
job](https://github.com/pytorch/executorch/actions/runs/41601038988/job/125799646998)
reaches the final CIFAR firmware link, then fails with `undefined
reference to SYS_INFO_PrintAll`. The SDK example calls this helper, but
our standalone CMake target omits
`examples/eiq_examples/common/sys_info/sys_info.c`.
Add that source to the firmware target. The helper also needs
`MCUXSDK_VERSION_FULL_STR`, which the SDK's normal build supplies
through a generated header. Our standalone target now uses the SDK's
`mcux_version.cmake` parser and sets the equivalent compile definition
from the checked-out SDK version.
## Verification
A focused host CMake build reused the actual example target's source
list and include paths, the real SDK helper/header, and the SDK version
parser. The board/runtime sources were replaced with empty fixtures and
the application with a small C++ caller.
The original source list reproduced the unresolved `SYS_INFO_PrintAll`
link error. Adding only the helper reproduced the missing
`MCUXSDK_VERSION_FULL_STR` compile error. With both changes, the
executable linked and printed `MCUX SDK version: 2026.12.00-pvw1`.
`git diff --check` passed. The full ARM firmware build and execution on
hardware were not run locally; the NXP CI job must validate the complete
build.
Only the example's CMakeLists.txt changes (eight added lines). The
resulting file is byte-identical to the verified release fix in pytorch#24509.
Land this on main; pytorch#24509 is the corresponding release/1.6 pick.
Prepared with OpenAI Codex.1 parent 186ca41 commit ee4b85b
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
86 | 94 | | |
87 | 95 | | |
88 | 96 | | |
| |||
0 commit comments