Skip to content

Commit d5cb595

Browse files
8KeepSS-JIA
authored andcommitted
AutoHeaders: migrate to explicit headers (batches 113-115)
Summary: Finish Angliru, Callm, CEA, RFLib, Folly, ExecuTorch, Deeplearning, Avatar, and Comms by declaring their inferred headers and removing their parent AutoHeaders opt-ins. Keep shared-wrapper changes with their callers, including the FRL and X3D prerequisites. Preserve existing globs, aliases, and selector behavior; remove redundant Folly and RFLib header references. Declare the IPNext capacity observer Flags header in its own push surface. This is part of the stack that deletes AutoHeaders from the fbcode macros. Authored with Codex. Reviewed By: IanChilds Differential Revision: D123477636
1 parent 9e47127 commit d5cb595

4 files changed

Lines changed: 8 additions & 3 deletions

File tree

‎backends/apple/coreml/targets.bzl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def define_common_targets(is_fbcode = False):
109109
],
110110
headers = glob([
111111
"runtime/inmemoryfs/**/*.hpp",
112-
]),
112+
]) + ["runtime/util/json_util.hpp"],
113113
base_module = "executorch.backends.apple.coreml",
114114
compiler_flags = [
115115
"-std=c++17",

‎extension/llm/runner/targets.bzl‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "get_aten_mode_options", "runtime")
1+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "is_xplat", "get_aten_mode_options", "runtime")
22

33
def define_common_targets():
44
runtime.cxx_library(
@@ -148,6 +148,7 @@ def define_common_targets():
148148
"llm_runner_helper.cpp",
149149
"multimodal_runner.cpp",
150150
],
151+
headers = ["multimodal_runner.h"] if not runtime.is_oss and not is_xplat() else [],
151152
visibility = ["PUBLIC"],
152153
compiler_flags = [
153154
"-Wno-missing-prototypes",

‎extension/pybindings/BUCK‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@ fbcode_target(
9191
_kind = cpp_python_extension,
9292
name = "data_loader",
9393
srcs = ["pybindings_data_loader.cpp"],
94+
headers = [
95+
"pybindings_data_loader.h",
96+
],
9497
base_module = "executorch.extension.pybindings",
9598
deps = [
9699
":data_loader_types",

‎runtime/platform/targets.bzl‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@fbsource//xplat/executorch/build:build_variables.bzl", "PLATFORM_SRCS")
2-
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
2+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "is_xplat", "runtime")
33
load(":log.bzl", "get_et_logging_flags")
44

55
def _select_pal(dict_):
@@ -75,6 +75,7 @@ def define_common_targets():
7575
"compat_unistd.h",
7676
],
7777
srcs = PLATFORM_SRCS,
78+
headers = ["platform.h"] if not runtime.is_oss and not is_xplat() else [],
7879
exported_preprocessor_flags = get_profiling_flags() + get_et_logging_flags(),
7980
exported_deps = [
8081
"//executorch/runtime/platform:pal_interface",

0 commit comments

Comments
 (0)