From a2beb5e0695a237318d64ccd04058ef0dedde397 Mon Sep 17 00:00:00 2001 From: JMS063 <121246951+JMS063@users.noreply.github.com> Date: Thu, 26 Oct 2023 23:08:48 +1100 Subject: [PATCH 1/8] fix issue#10507 changed the size of the button --- src/main/java/org/jabref/gui/EntryTypeView.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/org/jabref/gui/EntryTypeView.java b/src/main/java/org/jabref/gui/EntryTypeView.java index 6b4bb2f8f0a..63556459ae4 100644 --- a/src/main/java/org/jabref/gui/EntryTypeView.java +++ b/src/main/java/org/jabref/gui/EntryTypeView.java @@ -89,6 +89,8 @@ public EntryTypeView(LibraryTab libraryTab, DialogService dialogService, Prefere Button btnGenerate = (Button) this.getDialogPane().lookupButton(generateButton); + btnGenerate.setStyle("-fx-padding: 6 20px; -fx-min-width: 150px;"); // Changes the button length + btnGenerate.textProperty().bind(EasyBind.map(viewModel.searchingProperty(), searching -> searching ? Localization.lang("Searching...") : Localization.lang("Generate"))); btnGenerate.disableProperty().bind(viewModel.idFieldValidationStatus().validProperty().not().or(viewModel.searchingProperty())); From 7307b0b15d6b7b7ff0732c6264a702ff2378db32 Mon Sep 17 00:00:00 2001 From: JMS063 <121246951+JMS063@users.noreply.github.com> Date: Thu, 26 Oct 2023 23:17:59 +1100 Subject: [PATCH 2/8] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d4eae85d8d0..243d510440d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where scrolling was impossible on dragging a citation on the groups panel. [#9754](https://github.com/JabRef/jabref/issues/9754) - We fixed an issue where exporting "Embedded BibTeX pdf" without selecting an existing document would produce an exception. [#10101](https://github.com/JabRef/jabref/issues/10101) - We fixed an issue where it was not possible to connect to a shared database once a group with entries was added or other metadata modified [#10336](https://github.com/JabRef/jabref/issues/10336) +- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly.[#10507] ### Removed From ce3acce4e0be3bcae46d0cde4f10c5e18cf47dd2 Mon Sep 17 00:00:00 2001 From: JMS063 <121246951+JMS063@users.noreply.github.com> Date: Thu, 26 Oct 2023 23:18:25 +1100 Subject: [PATCH 3/8] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 243d510440d..e343cf648e6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,7 +51,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where scrolling was impossible on dragging a citation on the groups panel. [#9754](https://github.com/JabRef/jabref/issues/9754) - We fixed an issue where exporting "Embedded BibTeX pdf" without selecting an existing document would produce an exception. [#10101](https://github.com/JabRef/jabref/issues/10101) - We fixed an issue where it was not possible to connect to a shared database once a group with entries was added or other metadata modified [#10336](https://github.com/JabRef/jabref/issues/10336) -- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly.[#10507] +- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507] ### Removed From 71e22c8e5425d6f7ca11707d75c5ea3cfcaea050 Mon Sep 17 00:00:00 2001 From: JMS063 <121246951+JMS063@users.noreply.github.com> Date: Thu, 26 Oct 2023 23:19:28 +1100 Subject: [PATCH 4/8] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e343cf648e6..a7841476e86 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,7 +51,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where scrolling was impossible on dragging a citation on the groups panel. [#9754](https://github.com/JabRef/jabref/issues/9754) - We fixed an issue where exporting "Embedded BibTeX pdf" without selecting an existing document would produce an exception. [#10101](https://github.com/JabRef/jabref/issues/10101) - We fixed an issue where it was not possible to connect to a shared database once a group with entries was added or other metadata modified [#10336](https://github.com/JabRef/jabref/issues/10336) -- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507] +- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507](https://github.com/JabRef/jabref/issues/10507) ### Removed From d578ce9c5fc8e6a2abc42d137b78e2616e6f398e Mon Sep 17 00:00:00 2001 From: JMS063 <121246951+JMS063@users.noreply.github.com> Date: Thu, 26 Oct 2023 23:22:53 +1100 Subject: [PATCH 5/8] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a7841476e86..a7981ec78cc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,7 +51,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where scrolling was impossible on dragging a citation on the groups panel. [#9754](https://github.com/JabRef/jabref/issues/9754) - We fixed an issue where exporting "Embedded BibTeX pdf" without selecting an existing document would produce an exception. [#10101](https://github.com/JabRef/jabref/issues/10101) - We fixed an issue where it was not possible to connect to a shared database once a group with entries was added or other metadata modified [#10336](https://github.com/JabRef/jabref/issues/10336) -- We ficed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507](https://github.com/JabRef/jabref/issues/10507) +- We fixed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507](https://github.com/JabRef/jabref/issues/10507) ### Removed From bb51bae900240642bb57444bab1883cba4878b94 Mon Sep 17 00:00:00 2001 From: Minghao Date: Sun, 29 Oct 2023 17:12:13 +1100 Subject: [PATCH 6/8] fix issue #10507 --- src/main/java/org/jabref/gui/Base.css | 5 +++++ src/main/java/org/jabref/gui/EntryTypeView.java | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css index 68f96eebf28..c99862b69b8 100644 --- a/src/main/java/org/jabref/gui/Base.css +++ b/src/main/java/org/jabref/gui/Base.css @@ -1447,3 +1447,8 @@ We want to have a look that matches our icons in the tool-bar */ .table-column .rotated > .label { -fx-content-display: graphic-only; } + +.customGenerateButton { + -fx-padding: 0.5em 2em; /* Used 'em' values for scalability */ + -fx-min-width: 10em; /* This is just a placeholder value; adjust as necessary */ +} diff --git a/src/main/java/org/jabref/gui/EntryTypeView.java b/src/main/java/org/jabref/gui/EntryTypeView.java index 63556459ae4..238d80d7d17 100644 --- a/src/main/java/org/jabref/gui/EntryTypeView.java +++ b/src/main/java/org/jabref/gui/EntryTypeView.java @@ -88,8 +88,7 @@ public EntryTypeView(LibraryTab libraryTab, DialogService dialogService, Prefere }); Button btnGenerate = (Button) this.getDialogPane().lookupButton(generateButton); - - btnGenerate.setStyle("-fx-padding: 6 20px; -fx-min-width: 150px;"); // Changes the button length + btnGenerate.getStyleClass().add("customGenerateButton"); btnGenerate.textProperty().bind(EasyBind.map(viewModel.searchingProperty(), searching -> searching ? Localization.lang("Searching...") : Localization.lang("Generate"))); btnGenerate.disableProperty().bind(viewModel.idFieldValidationStatus().validProperty().not().or(viewModel.searchingProperty())); From 405723627936c7601aeffff03ef675a559acac45 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Thu, 2 Nov 2023 21:13:41 +0100 Subject: [PATCH 7/8] Generified changelog entry for small visual fixes --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c3258058ae..96737957751 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where the added protected term has unwanted leading and trailing whitespaces, where the formatted text has unwanted empty brackets and where the word at the cursor in the textbox can be added to the list [#10415](https://github.com/JabRef/jabref/issues/10415). - We fixed an issue where in the merge dialog the file field of entries was not correctly merged when the first and second entry both contained values inside the file field [#10572](https://github.com/JabRef/jabref/issues/10572) +- We fixed some small inconsistencies in the user interface. [#10507](https://github.com/JabRef/jabref/issues/10507) ### Removed @@ -76,7 +77,6 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where exporting "Embedded BibTeX pdf" without selecting an existing document would produce an exception. [#10101](https://github.com/JabRef/jabref/issues/10101) - We fixed an issue where there was a failure to access the url link for "eprint" for the ArXiv entry.[#10474](https://github.com/JabRef/jabref/issues/10474) - We fixed an issue where it was not possible to connect to a shared database once a group with entries was added or other metadata modified [#10336](https://github.com/JabRef/jabref/issues/10336) -- We fixed an issue where after clicking the "Generate" button the "Searching..." will not show correctly. [#10507](https://github.com/JabRef/jabref/issues/10507) - We fixed an issue where middle-button paste in X not always worked [#7905](https://github.com/JabRef/jabref/issues/7905) ## [5.10] – 2023-09-02 From 2d57d1fa02fd3bfc905066ecb23d3fe5a063fb5f Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Thu, 2 Nov 2023 21:17:57 +0100 Subject: [PATCH 8/8] Update Base.css --- src/main/java/org/jabref/gui/Base.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css index c99862b69b8..8aa35586865 100644 --- a/src/main/java/org/jabref/gui/Base.css +++ b/src/main/java/org/jabref/gui/Base.css @@ -1449,6 +1449,6 @@ We want to have a look that matches our icons in the tool-bar */ } .customGenerateButton { - -fx-padding: 0.5em 2em; /* Used 'em' values for scalability */ - -fx-min-width: 10em; /* This is just a placeholder value; adjust as necessary */ + -fx-padding: 0.5em 2em; + -fx-min-width: 10em; }