Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tab shown when untitled tab is created #12680

Open
2 tasks done
Paras-Gupta16 opened this issue Mar 10, 2025 · 7 comments
Open
2 tasks done

No tab shown when untitled tab is created #12680

Paras-Gupta16 opened this issue Mar 10, 2025 · 7 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui

Comments

@Paras-Gupta16
Copy link
Contributor

Paras-Gupta16 commented Mar 10, 2025

JabRef version

5.15 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Set preference to true for "Hide tab bar when single library is present"
  2. Create a new library
  3. Change the preference to false.
  4. Now in tab bar no tab is shown.
@Paras-Gupta16
Copy link
Contributor Author

Paras-Gupta16 commented Mar 10, 2025

This is video for more context.

Recording.2025-03-11.000517.mp4

@koppor koppor mentioned this issue Mar 10, 2025
7 tasks
@koppor
Copy link
Member

koppor commented Mar 10, 2025

PR introducing the feature was: #12395 - maybe you see which code causes the issue.

@priyanshu16095
Copy link
Contributor

priyanshu16095 commented Mar 10, 2025

This implementation was also enhanced in this PR #12496

@Paras-Gupta16
Copy link
Contributor Author

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 10, 2025
Copy link
Contributor

👋 Hey @Paras-Gupta16, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 24 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@Paras-Gupta16
Copy link
Contributor Author

Tried it with using the code of this branch #12395, it works fine!

@koppor
Copy link
Member

koppor commented Mar 11, 2025

Tried it with using the code of this branch #12395, it works fine!

This means, some issue was introduced since then? Maybe use git bisect to find out the commit which is causing harm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui
Projects
None yet
Development

No branches or pull requests

3 participants