Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make strings consistent #12566

Closed
koppor opened this issue Feb 24, 2025 · 7 comments · Fixed by #12587 · May be fixed by dhanashreep7853/jabref#1
Closed

Make strings consistent #12566

koppor opened this issue Feb 24, 2025 · 7 comments · Fixed by #12587 · May be fixed by dhanashreep7853/jabref#1
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: entry-editor component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Feb 24, 2025

There are two functionalities for renamign attached files.

In the entry editor

Image

in "Quality" > "Cleanup entries"

Image

The text of both menu entries should be the same. It needs to be changed to

Rename files to configured filename format pattern

Change "Filename format pattern:" to "Filename format pattern (from preferences)"

Also change "Rename only PDFs having a relative path" to "Rename files having a relative path only"

See #12565 for a step-by-step instruction for triggering rename of a single file in the entry editor.


Hint: https://devdocs.jabref.org/code-howtos/localization.html

Related: #11368

@koppor koppor added component: entry-editor component: preferences good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Feb 24, 2025
@Siedlerchr Siedlerchr changed the title Make strings consitent Make strings consistent Feb 24, 2025
@MhammedAhmmed
Copy link
Contributor

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 25, 2025
Copy link
Contributor

👋 Hey @MhammedAhmmed, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 11 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Feb 26, 2025
@ryan-carpenter
Copy link

Change "Filename format pattern:" to "Filename format pattern (from preferences)"
Also change "Rename only PDFs having a relative path" to "Rename files having a relative path only"

Consider:

  • Rename files according to preset pattern: (from preferences)
    • Only rename files that have a relative path

@MhammedAhmmed
Copy link
Contributor

Just to make I am understand correctly, do you mean
Change "Filename format pattern:" to "Rename files according to preset pattern: (from preferences)" Also Change "Rename only PDFs having a relative path" to "Only rename files that have a relative path" ? @ryan-carpenter

@ryan-carpenter
Copy link

There are several more inconsistencies to fix in this view, such as the naming and formatting of field references.

Image

@dhanashreep7853
Copy link

"The action RENAME_FILE_TO_PATTERN exists in StandardActions.java, but I couldn’t find where it is actually implemented. This may indicate that the renaming functionality is missing or incomplete. Should we add the logic to handle renaming files based on a defined pattern?"

@Siedlerchr
Copy link
Member

RENAME_FILE_TO_PATTERN is for the context menu (Tip: use intellijs find usages to find the source)
For thi sissue one needs to look into the CleanupWorker to see the actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: entry-editor component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Done
Status: Done
5 participants