Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JaCoCo #12171

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Update JaCoCo #12171

merged 4 commits into from
Nov 11, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 10, 2024

Follow-up to #12166

JaCoCo needs to be updated to support JDK23. (Refs jacoco/jacoco#1757)

Changes: https://www.jacoco.org/jacoco/trunk/doc/changes.html

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Nov 10, 2024
jabref-machine
jabref-machine previously approved these changes Nov 10, 2024
@koppor koppor added this to the 6.0-beta milestone Nov 10, 2024
@Siedlerchr
Copy link
Member

Could not find org.jacoco:org.jacoco.agent:0.8.13.202411081104.

@Siedlerchr
Copy link
Member

seems like they don't have that older snapshot build

@koppor
Copy link
Member Author

koppor commented Nov 11, 2024

seems like they don't have that older snapshot build

I don't find any snapshot build on maven central...

@Siedlerchr
Copy link
Member

This version still a snapshot build, it shoudl be available from sonatype
#https://www.jacoco.org/jacoco/trunk/doc/repo.html

Copy link
Contributor

github-actions bot commented Nov 11, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 71b238c Nov 11, 2024
30 of 31 checks passed
@koppor koppor deleted the update-jacoco branch November 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is tagged with that label will be merged if workflows are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants