Skip to content

matchPullRequestTarget is dead code left behind in loopover-extension/content.js by #7487's issue-page match removal #8023

Description

@JSONbored

Context

apps/loopover-extension/content.js, lines 16-20, defines matchPullRequestTarget — a function that duplicates what matchGitHubPageTarget already does, minus the kind field.

#7487 removed issue-page matching from matchGitHubPageTarget (the manifest.json content-script match is now pull/* only) and simplified the if (target) guard, but left matchPullRequestTarget behind. Confirmed via git log -p that it's genuinely stranded, not used anywhere in production — it's only re-exported through the __loopoverContentInternals test-hook object (line 195), and apps/loopover-extension has zero test files (unlike its sibling apps/loopover-miner-extension, which has a full test/ directory), so even that test-internals export is unconsumed.

Requirements

  • Remove matchPullRequestTarget and its entry in the __loopoverContentInternals export.
  • Confirm no other file references it (grep before removing).

Deliverables

  • matchPullRequestTarget deleted from content.js.
  • __loopoverContentInternals no longer exports it.

Test Coverage Requirements

Dead-code removal with no behavior change — no new test needed; confirm the extension still loads/functions unchanged (existing manual verification convention for this extension, since it has no automated test suite).

Expected Outcome

content.js no longer carries a stranded duplicate of matchGitHubPageTarget's logic from before #7487's simplification.

Links & Resources

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions