Skip to content

3 tables in apps/loopover-ui hand-roll raw <table> markup instead of the shared Table component #6986

Description

@JSONbored

Context

Three files in apps/loopover-ui hand-roll raw <table>/<thead>/<tbody> markup instead of adopting the shared Table component (@/components/ui/table, a ui-kit-backed primitive):

  • apps/loopover-ui/src/components/site/check-run-readiness-table.tsx:65
  • apps/loopover-ui/src/components/site/command-table.tsx:41
  • apps/loopover-ui/src/components/site/app-panels/contributor-quality-table.tsx:35

None of the three import Table from @/components/ui/table (confirmed — no such import in any of the three files). This is the same class of gap epic #6504 already fixed for apps/loopover-miner-ui's tables, applied here to three tables in the main website app that were never audited for it.

Requirements

  • Migrate all three tables' markup onto the shared Table/TableHeader/TableBody/TableRow/TableCell components from @/components/ui/table.
  • Preserve each table's existing columns, sorting/formatting logic, and any per-cell styling (e.g. contributor-quality-table.tsx's whitespace-nowrap) — this issue is about the markup/component, not the data or layout.
  • Do not invent a new table wrapper component — only migrating to the existing shared Table primitive satisfies this issue.

Deliverables

  • check-run-readiness-table.tsx uses Table
  • command-table.tsx uses Table
  • contributor-quality-table.tsx uses Table
  • Test(s) confirming each table still renders its existing rows/columns correctly after migration

Test Coverage Requirements

apps/** UI code falls outside this repo's strict Codecov patch gate (check coverage.include) — a before/after screenshot table (all three components) is still required per this repo's UI-PR convention, plus the regression tests above.

Expected Outcome

All three tables render through the shared Table primitive instead of raw hand-rolled <table> markup, matching the rest of the app's adopted convention.

Links & Resources

@/components/ui/table — the Table primitive. Any apps/loopover-miner-ui route already migrated under epic #6504 for a real before/after precedent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions